commit 6fcad835fbd1cba379f34ecb96755888d21a98df
author Cheng Chen <chengchen@google.com> Mon Jan 22 16:59:05 2024 -0800
committer Cheng Chen <chengchen@google.com> Tue Jan 23 18:06:14 2024 +0000
tree a0c97935f631f25ba42edb611f9282c20ce5fb0a
parent 9ac2af6c3d88c7c2848cc502c3b0bb01ea452c58

Zero initialize an array in cdef search

This array was not initialized.

The array is supposed to store the best corresponding cdef filter
strength. And its value is an index of another array.

Without the initialization, this might lead to out of bound access
to the other array.

Change-Id: Id65c448f479865992ada0b09ff6e97b2d2ac3362

av1/encoder/pickcdef.c

diff --git a/av1/encoder/pickcdef.c b/av1/encoder/pickcdef.c
index 232a2f9..ed5fa55 100644
--- a/av1/encoder/pickcdef.c
+++ b/av1/encoder/pickcdef.c
@@ -894,7 +894,7 @@
   int rdmult = cpi->td.mb.rdmult;
   for (int i = 0; i <= 3; i++) {
     if (i > max_signaling_bits) break;
-    int best_lev0[CDEF_MAX_STRENGTHS];
+    int best_lev0[CDEF_MAX_STRENGTHS] = { 0 };
     int best_lev1[CDEF_MAX_STRENGTHS] = { 0 };
     const int nb_strengths = 1 << i;
     uint64_t tot_mse;