)]}'
{
  "commit": "e9545b218916ca66d5c20537b5835e3397c602de",
  "tree": "16a37f3001a2292713ab4ddc566d6e4a790fe12a",
  "parents": [
    "6f2b56c602d31bd154d510cafc1bbbf8c1b4b42f"
  ],
  "author": {
    "name": "Rachel Barker",
    "email": "rachelbarker@google.com",
    "time": "Mon Dec 11 14:32:24 2023 +0000"
  },
  "committer": {
    "name": "Wan-Teh Chang",
    "email": "wtc@google.com",
    "time": "Thu Jan 18 07:42:00 2024 -0800"
  },
  "message": "Fix a range check in disflow\n\nIn compute_flow_error(), we split a floating point value into integer\nand floating point parts as follows:\n\n    const int v_int \u003d (int)floor(v);\n    const double v_frac \u003d v - floor(v);\n\nThis gets passed down to get_cubic_kernel_dbl(x \u003d v_frac), which\nasserts:\n\n    assert(0 \u003c\u003d x \u0026\u0026 x \u003c 1);\n\nHowever, there is an edge case where v_frac can be equal to 1, if v\nis very slightly less than an integer. For example, in the linked\nbug report, v \u003d -5.5...e-17, which leads to v_int \u003d -1 and v_frac \u003d 1\ndue to floating point rounding.\n\nThe current code actually handles this case perfectly fine, so all\nthat needs to be done is to change the range of the assertion to\n\n    assert(0 \u003c\u003d x \u0026\u0026 x \u003c\u003d 1);\n\nin all places where this code appears.\n\nBug: aomedia:3520\nChange-Id: If3f89f36b5bad360c1459a2573fe02794b3ab2a7\n(cherry picked from commit 15bcf20ce83af7549714bc20133a17b5348f00bd)\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "a8e7b06f0cca8bd66927ce7deac5a994790c46e0",
      "old_mode": 33188,
      "old_path": "aom_dsp/flow_estimation/disflow.c",
      "new_id": "ad8d659432d75221c21a2abec5d693e00bfc356b",
      "new_mode": 33188,
      "new_path": "aom_dsp/flow_estimation/disflow.c"
    },
    {
      "type": "modify",
      "old_id": "a62e9a4d970685745e1c7307a0f44762ffcd2528",
      "old_mode": 33188,
      "old_path": "aom_dsp/flow_estimation/x86/disflow_sse4.c",
      "new_id": "37170fe9ba4bd5e3e626e0b7f1cd43ed492a5460",
      "new_mode": 33188,
      "new_path": "aom_dsp/flow_estimation/x86/disflow_sse4.c"
    }
  ]
}