tree ecb2144d7835874effc5ad228d116c0057415ae9
parent fdc480f807ff5e566c89e1ca6a042d17cf51ec3c
author Wan-Teh Chang <wtc@google.com> 1540507344 -0700
committer Wan-Teh Chang <wtc@google.com> 1540573962 +0000

Assert the ref_cnt_fb() call won't leak raw buffer

The decoder always calls decrease_ref_count() to decrement a frame
buffer's ref_count. The only exception is this ref_cnt_fb() call, which
decrements the ref_count directly.

decrease_ref_count() takes care of calling release_fb_cb(), so this
ref_cnt_fb() call may potentially leak a raw frame buffer. There are two
ways to address this.

1. Replace the ref_cnt_fb() call with equivalent code that calls
decrease_ref_count().

2. Verify that this ref_cnt_fb() call won't leak reference.

This CL does the latter. It adds assertions to verify that the current
cm->new_fb_idx has not yet allocated a raw frame buffer and therfore the
ref_cnt_fb() call won't leak a raw frame buffer.

BUG=aomedia:2179

Change-Id: I538b2344c8f964d057f913c73a357af8cc3a4c82