tree d2301247601654e20d873dfb6d7903aa3c85bd22
parent aa1a2190612c86f80af5fbf6562ef26bea326458
author Wan-Teh Chang <wtc@google.com> 1593730317 -0700
committer Wan-Teh Chang <wtc@google.com> 1594072789 +0000

Clean up aom_image_t metadata allocation functions

aom_img_add_metadata() (a public function) and alloc_read_metadata() (a
static function in av1/decoder/obu.c) both add a new aom_metadata_t to
an aom_metadata_array_t. They differ only in
  1) who owns the aom_metadata_array_t (aom_image_t vs. AV1Decoder), and
  2) the error reporting method (return value vs. aom_internal_error()).
Make the logic of the two functions as similar as possible. In
particular, aom_img_add_metadata() no longer frees the img->metadata
array on failure. This rewrite also fixes the leak of the old
img->metadata->metadata_array in aom_img_add_metadata() if the realloc()
call fails.

Improve the comments for some aom_image_t metadata allocation functions.

Change-Id: I20fa46934f112b4d0727ad848ac9c8a335183bf9