commit 4d53e30f7d8fd1abf873040eb7d15230492930ff
author Martin Storsjo <martin@martin.st> Mon Sep 07 14:11:05 2020 +0300
committer James Zern <jzern@google.com> Tue Sep 08 18:51:43 2020 +0000
tree d5ef91c83d0aaaec39944d5cd01a7feac6acdb0c
parent 6eaea623d2f9307f59028e448ed63a321c29f376

neon: Fix building with clang after fb78faa4714f616ea7

Previously, building with clang failed with errors like this:

aom_dsp/arm/sad_neon.c:422:14: error: argument to '__builtin_neon_vget_lane_i16' must be a constant integer
      sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), x);

Change-Id: I076f9f4801feba4d1ee2eb3748110003fb7a5758

aom_dsp/arm/sad_neon.c

diff --git a/aom_dsp/arm/sad_neon.c b/aom_dsp/arm/sad_neon.c
index 17d9994..32b9e9d 100644
--- a/aom_dsp/arm/sad_neon.c
+++ b/aom_dsp/arm/sad_neon.c
@@ -418,12 +418,16 @@
   for (int i = 0; i < h; i++) {
     uint8x8_t q0 = vld1_u8(src_ptr);
     uint8x8_t q1 = vld1_u8(ref_ptr);
-    for (int x = 0; x < 4; x++)
-      sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), x);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 0);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 1);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 2);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 3);
     q0 = vld1_u8(src_ptr + 8);
     q1 = vld1_u8(ref_ptr + 8);
-    for (int x = 0; x < 4; x++)
-      sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), x);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 0);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 1);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 2);
+    sum += vget_lane_u16(vpaddl_u8(vabd_u8(q0, q1)), 3);
 
     src_ptr += src_stride;
     ref_ptr += ref_stride;