)]}'
{
  "commit": "71ed044e59ad8981a7a2f34709dff9c453e59199",
  "tree": "7c2f226da0058467eb7ac13e00c0a015bd96178e",
  "parents": [
    "7ee83b59c712925e8b701f8d0fe217c9d48bf5cb"
  ],
  "author": {
    "name": "Ruoyu Zhong",
    "email": "zhongruoyu@outlook.com",
    "time": "Sun Sep 03 13:41:28 2023 +0800"
  },
  "committer": {
    "name": "Wan-Teh Chang",
    "email": "wtc@google.com",
    "time": "Fri Jan 12 19:52:31 2024 +0000"
  },
  "message": "cmake: improve ASM compiler config for arm64 macOS\n\nOn arm64 macOS, cmake configuration for aom 3.7.0 hangs indefinitely.\nThis is due to commit a250c26cade, where `CMAKE_ASM_COMPILER` is\nunconditionally set to `as` on arm64 macOS regardless of the user\u0027s\nsettings; later during the `enable_language(ASM)` invocation, the\nassembler `/usr/bin/as` is invoked with the argument `-Wl,--help`, but\nthe argument is ignored:\n\n    $ /usr/bin/as -Wl,--help\n    clang: warning: -Wl,--help: \u0027linker\u0027 input unused [-Wunused-command-line-argument]\n\nAnd, it hangs indefinitely because it expects input from standard input\nby default.\n\nA minimal reproducer for this (on x86_64 or arm64 macOS) is to have the\nfollowing in `CMakeLists.txt`:\n\n    include(CheckLanguage)\n    set(CMAKE_ASM_COMPILER as)\n    enable_language(ASM)\n\nAnd run `cmake -S . -B build --trace`.\n\nWe can fix that by setting `CMAKE_ASM_COMPILER` to `CMAKE_C_COMPILER` by\ndefault. This is also consistent with CMake\u0027s default behaviour. (Try\ncommenting the `set(CMAKE_ASM_COMPILER)` line above to check; see also:\n[^1].) In addition, if `CMAKE_ASM_COMPILER` is already defined (by, for\nexample, passing `-DCMAKE_ASM_COMPILER\u003das` to `cmake`), respect that\nconfiguration.\n\n[^1]: https://github.com/Kitware/CMake/blob/v3.27.0/Modules/CMakeDetermineASMCompiler.cmake\n\nChange-Id: I48c0a0e7d22aeaa310a35155d93706210662a547\nSigned-off-by: Ruoyu Zhong \u003czhongruoyu@outlook.com\u003e\n(cherry picked from commit ce2e55d0d7efd49706929a36606c60bf53733bfb)\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "6c932e86c8b82d6bca1bac1fe122d1a964fba441",
      "old_mode": 33188,
      "old_path": "build/cmake/aom_configure.cmake",
      "new_id": "917e7cac5dff2d6ed48d9cfdf0e5f51fe799612a",
      "new_mode": 33188,
      "new_path": "build/cmake/aom_configure.cmake"
    }
  ]
}