tree 84e6a609d8f509c87c6ca90a1a5c5b6d1ac1750c
parent 560a39293ab1bf8ac8270736a695c8c998dee339
author Elliott Karpilovsky <elliottk@google.com> 1588299567 -0700
committer Jerome Jiang <jianj@google.com> 1588802470 +0000

Remove surprises from aom_codec_control

The aom_codec_control API has surprising behavior:

----
aom_codec_control(&ctx, AOME_SET_CPUUSED, 8);  // Fine

int ctrl_id = AOME_SET_CPUUSED;
aom_codec_control(&ctx, ctrl_id, 8);  // Compiler error
----

aom_codec_control is a macro that expands to
aom_codec_control_##ctrl_id for each control type.
When users encounter the above problem, they must either
call aom_codec_control_ (which is the underlying function
without type-checking) or define AOM_DISABLE_CTRL_TYPECHECKS.
Due to this behavior, both versions are used in the codebase.

This patch:

1. Renames aom_codec_control_ to aom_codec_control
2. Creates the macro AOM_CODEC_CONTROL_TYPECHECKED to perform
   the same type-checking as before, with a simpler implementation

Note that the macro-define AOM_DISABLE_CTRL_TYPECHECKS is no longer
checked; when upgrading to libaom 2.0.0, it is advised to remove
references to this macro-define.

BUG=aomedia:2651

Change-Id: Ic2ec82ccc7a5b68f9a3fe6185f8fc297b4fcafd7
(cherry picked from commit 60dd0f988ec989c998a418dc8b9511c267248c0c)