commit ad5fd34ad9058384a55196f66e2001cc8c2c523f
author Wan-Teh Chang <wtc@google.com> Mon Apr 29 13:29:14 2024 -0700
committer James Zern <jzern@google.com> Mon Apr 29 13:32:53 2024 -0700
tree f17d59bf434c7128fc15906b252caa23d14619e7
parent 4073590b26a546add973fb0f455b3c46d165c5d7

Ensure thread stack size is at least 256 KB

Fixes cases like musl where the default is lower:
https://wiki.musl-libc.org/functional-differences-from-glibc.html#Thread-stack-size

Bug: aomedia:2754, aomedia:3567
Change-Id: Ia6e211f9b87bc2efe376e7b9f4adb11741850b18

aom_util/aom_thread.c

diff --git a/aom_util/aom_thread.c b/aom_util/aom_thread.c
index bdf2b7d..783ffac 100644
--- a/aom_util/aom_thread.c
+++ b/aom_util/aom_thread.c
@@ -156,16 +156,18 @@
       // See: https://crbug.com/aomedia/3379
 #if defined(AOM_ADDRESS_SANITIZER) && defined(__APPLE__) && AOM_ARCH_ARM && \
     !defined(NDEBUG)
+    const size_t kMinStackSize = 1024 * 1024;
+#else
+    const size_t kMinStackSize = 256 * 1024;
+#endif
     size_t stacksize;
     if (!pthread_attr_getstacksize(&attr, &stacksize)) {
-      const size_t kMinStackSize = 1 << 20;  // 1 MiB
       if (stacksize < kMinStackSize &&
           pthread_attr_setstacksize(&attr, kMinStackSize)) {
         pthread_attr_destroy(&attr);
         goto Error2;
       }
     }
-#endif
     pthread_mutex_lock(&worker->impl_->mutex_);
     ok = !pthread_create(&worker->impl_->thread_, &attr, thread_loop, worker);
     if (ok) worker->status_ = AVX_WORKER_STATUS_OK;