tree ed721c1edf255019e9c42923fe3f7bdcfdcbe9c1
parent 5aa64a71c64921d21fecc10973b6dbb7e794547d
author Johann <johann.koenig@duck.com> 1539012995 -0700
committer Johann Koenig <johannkoenig@google.com> 1539182648 +0000

Fix stack corruption with x86 and --enable-pic

x86inc.asm's cglobal macro is frequently used to declare more
arguments than the function actually has. Normally, this is
done to aquire an alias to a register that would correspond to
that positional function argument if it existed. This is safe
when used in this manner.
In the case fixed here, however, the alias is used to temporarily
store adresses obtained through the GOT in memory. Because those
extra arguments don't actually exist, those stores corrupt the
callers stack frame.
SSE2/VpxHBDSubpelVarianceTest.Ref is a test that may fail as a
result.
To simply fix the space allocated to actual arguments that have
been loaded into registers already is reused.
This avoids having to allocate extra space for local variables.

Also removed duplicate code while at it.

(cherry picked from libvpx commit 347d01811538f89fac6ffb34af3adf87dc945822)
Submitted on behalf of a third party: Matthias Räncker <theonetruecamper@gmx.de>

Change-Id: I505281ecaa6be586185fe6a2d34d62bdf40c839f