tree 4be24d7015eabb58598fc37e060563fb2ccd79fe
parent 04737b7a8e46f69fbc8eae120f01e2c013b670e7
author Ranjit Kumar Tulabandu <ranjit.tulabandu@ittiam.com> 1659957306 +0530
committer Marco Paniconi <marpan@google.com> 1660083008 +0000

Fix source buffer access in rc_scene_detection_onepass_rt()

In rc_scene_detection_onepass_rt(), source buffers of current
and last input frames were accessed using cpi->unscaled_source
and cpi->unscaled_last_source. These pointers were initialized
in av1_encode(), which is called after
rc_scene_detection_onepass_rt(). Hence the local pointer
unscaled_src in rc_scene_detection_onepass_rt() points to last
frame and vice versa. Though the SAD was computed for last
source frame w.r.t current source frame, the metrics like
cpi->rc.frame_source_sad etc. are seen to be correct for all
frames except first inter frame. For first inter frame, SAD
values were not computed as unscaled_last_src was NULL and
cpi->rc.frame_source_sad is considered as zero in this case.
This CL fixes the issue by initializing these local pointers
from frame_input which is initialized correctly.

For rtc-screen,

          Instruction Count        BD-Rate Loss(%)
cpu-used    Reduction(%)    avg.psnr   ovr.psnr    ssim
    7         -0.543        -0.2794     0.5159    0.7707
    8          0.139         0.0810    -0.0130    0.1490
    9          0.445        -0.4881    -0.1066   -0.0806
    10         0.051        -0.0661     0.0410    0.0473

STATS_CHANGED for rt

Change-Id: Ie620d3a89c3b9f8a9f6528bdf020780a295520e9