commit 0154f2b5b426e55d014649c9a9258fef4c940d8b
author Yaowu Xu <yaowu@google.com> Thu Jan 04 09:01:17 2018 -0800
committer Yaowu Xu <yaowu@google.com> Thu Jan 04 09:05:13 2018 -0800
tree 5394676d6bfcf3604088316a5524296ec39c9ae3
parent 0f191dac608b94c7f7d8ffbcb04b33aa53e08c36

Fix several static analysis warnings

1. reduce the scope of low_qc_cost in encodetxb.c
2. add initialization of signs[] in decodetxb.c

Change-Id: I8dfb9f69c064ec3d23752df7aaec95249f270c22

av1/encoder/encodetxb.c

diff --git a/av1/encoder/encodetxb.c b/av1/encoder/encodetxb.c
index 98f200a..785b35e 100644
--- a/av1/encoder/encodetxb.c
+++ b/av1/encoder/encodetxb.c
@@ -329,11 +329,9 @@
   stats->rd = RDCOST(txb_info->rdmult, stats->rate, stats->dist);
 
   stats->low_qc = get_lower_coeff(qc);
-  int low_qc_cost;
 
 #if CONFIG_LV_MAP_MULTI
   if (is_eob && stats->low_qc == 0) {
-    low_qc_cost = qc_cost;
     stats->rd_low = stats->rd;  // disable selection of low_qc in this case.
   } else {
 #else
@@ -346,11 +344,11 @@
                                        dqv, txb_info->shift);
     const int64_t low_dqc_dist =
         get_coeff_dist(tqc, stats->low_dqc, txb_info->shift);
-    low_qc_cost = get_coeff_cost(stats->low_qc, scan_idx,
+    const int low_qc_cost = get_coeff_cost(stats->low_qc, scan_idx,
 #if CONFIG_LV_MAP_MULTI
-                                 is_eob,
+                                           is_eob,
 #endif
-                                 txb_info, txb_costs, coeff_ctx);
+                                           txb_info, txb_costs, coeff_ctx);
     stats->dist_low = low_dqc_dist - stats->dist0;
     stats->rate_low = low_qc_cost;
     stats->rd_low = RDCOST(txb_info->rdmult, stats->rate_low, stats->dist_low);