commit 332b2ae6fcb3b86203ef394437fc1fcfa87c0acf
author Wan-Teh Chang <wtc@google.com> Mon Jul 09 14:30:20 2018 -0700
committer Wan-Teh Chang <wtc@google.com> Mon Jul 09 14:35:07 2018 -0700
tree 5362cd3202077afc5fcafd4411bd4c37715aa906
parent f4fe66157ffe6cf72cd7c115e811be932b66c87a

Fix av1_receive_compressed_data error reporting.

The caller of av1_receive_compressed_data() expects it to set
cm->error.error_code to a nonzero error code and return a nonzero value
on error. So av1_receive_compressed_data() should do that after a
get_free_fb() failure.

Document this contract of av1_receive_compressed_data().

BUG=oss-fuzz:9288

Change-Id: I57c8725785182fd9d0993cd3d5cd87f0e0bf004f

av1/decoder/decoder.c

diff --git a/av1/decoder/decoder.c b/av1/decoder/decoder.c
index cad6c29..ef0d5e4 100644
--- a/av1/decoder/decoder.c
+++ b/av1/decoder/decoder.c
@@ -426,7 +426,10 @@
 
   // Find a free frame buffer. Return error if can not find any.
   cm->new_fb_idx = get_free_fb(cm);
-  if (cm->new_fb_idx == INVALID_IDX) return AOM_CODEC_MEM_ERROR;
+  if (cm->new_fb_idx == INVALID_IDX) {
+    cm->error.error_code = AOM_CODEC_MEM_ERROR;
+    return 1;
+  }
 
   // Assign a MV array to the frame buffer.
   cm->cur_frame = &pool->frame_bufs[cm->new_fb_idx];