Rename contexts in MACROBLOCKD, MACROBLOCKD_PLANE Match them with new names in CommonContexts (part of AV1_COMMON), to ensure they explicitly name the type of context they are referring to. Rename the relevant function too for clarity. BUG=aomedia:2610 Change-Id: I9de0d0dcd61bea5fe3916a1ae7763ea9d26675f4
diff --git a/av1/encoder/encodeframe.c b/av1/encoder/encodeframe.c index 1f59d8b..fbff008 100644 --- a/av1/encoder/encodeframe.c +++ b/av1/encoder/encodeframe.c
@@ -396,7 +396,7 @@ set_mode_info_offsets(cpi, x, xd, mi_row, mi_col); - set_skip_context(xd, mi_row, mi_col, num_planes); + set_entropy_context(xd, mi_row, mi_col, num_planes); xd->above_txfm_context = cm->above_contexts.txfm[tile->tile_row] + mi_col; xd->left_txfm_context = xd->left_txfm_context_buffer + (mi_row & MAX_MIB_MASK); @@ -1499,19 +1499,20 @@ for (p = 0; p < num_planes; p++) { int tx_col = mi_col; int tx_row = mi_row & MAX_MIB_MASK; - memcpy(xd->above_context[p] + (tx_col >> xd->plane[p].subsampling_x), - ctx->a + num_4x4_blocks_wide * p, - (sizeof(ENTROPY_CONTEXT) * num_4x4_blocks_wide) >> - xd->plane[p].subsampling_x); - memcpy(xd->left_context[p] + (tx_row >> xd->plane[p].subsampling_y), + memcpy( + xd->above_entropy_context[p] + (tx_col >> xd->plane[p].subsampling_x), + ctx->a + num_4x4_blocks_wide * p, + (sizeof(ENTROPY_CONTEXT) * num_4x4_blocks_wide) >> + xd->plane[p].subsampling_x); + memcpy(xd->left_entropy_context[p] + (tx_row >> xd->plane[p].subsampling_y), ctx->l + num_4x4_blocks_high * p, (sizeof(ENTROPY_CONTEXT) * num_4x4_blocks_high) >> xd->plane[p].subsampling_y); } - memcpy(xd->above_seg_context + mi_col, ctx->sa, - sizeof(*xd->above_seg_context) * mi_width); - memcpy(xd->left_seg_context + (mi_row & MAX_MIB_MASK), ctx->sl, - sizeof(xd->left_seg_context[0]) * mi_height); + memcpy(xd->above_partition_context + mi_col, ctx->sa, + sizeof(*xd->above_partition_context) * mi_width); + memcpy(xd->left_partition_context + (mi_row & MAX_MIB_MASK), ctx->sl, + sizeof(xd->left_partition_context[0]) * mi_height); xd->above_txfm_context = ctx->p_ta; xd->left_txfm_context = ctx->p_tl; memcpy(xd->above_txfm_context, ctx->ta, @@ -1533,17 +1534,18 @@ for (p = 0; p < num_planes; ++p) { int tx_col = mi_col; int tx_row = mi_row & MAX_MIB_MASK; - memcpy(ctx->a + mi_width * p, - xd->above_context[p] + (tx_col >> xd->plane[p].subsampling_x), - (sizeof(ENTROPY_CONTEXT) * mi_width) >> xd->plane[p].subsampling_x); + memcpy( + ctx->a + mi_width * p, + xd->above_entropy_context[p] + (tx_col >> xd->plane[p].subsampling_x), + (sizeof(ENTROPY_CONTEXT) * mi_width) >> xd->plane[p].subsampling_x); memcpy(ctx->l + mi_height * p, - xd->left_context[p] + (tx_row >> xd->plane[p].subsampling_y), + xd->left_entropy_context[p] + (tx_row >> xd->plane[p].subsampling_y), (sizeof(ENTROPY_CONTEXT) * mi_height) >> xd->plane[p].subsampling_y); } - memcpy(ctx->sa, xd->above_seg_context + mi_col, - sizeof(*xd->above_seg_context) * mi_width); - memcpy(ctx->sl, xd->left_seg_context + (mi_row & MAX_MIB_MASK), - sizeof(xd->left_seg_context[0]) * mi_height); + memcpy(ctx->sa, xd->above_partition_context + mi_col, + sizeof(*xd->above_partition_context) * mi_width); + memcpy(ctx->sl, xd->left_partition_context + (mi_row & MAX_MIB_MASK), + sizeof(xd->left_partition_context[0]) * mi_height); memcpy(ctx->ta, xd->above_txfm_context, sizeof(*xd->above_txfm_context) * mi_width); memcpy(ctx->tl, xd->left_txfm_context,
diff --git a/av1/encoder/encodetxb.c b/av1/encoder/encodetxb.c index 046d66e..fc5a851 100644 --- a/av1/encoder/encodetxb.c +++ b/av1/encoder/encodetxb.c
@@ -2092,8 +2092,9 @@ if (args->dry_run == OUTPUT_ENABLED) { MB_MODE_INFO *mbmi = xd->mi[0]; TXB_CTX txb_ctx; - get_txb_ctx(plane_bsize, tx_size, plane, pd->above_context + blk_col, - pd->left_context + blk_row, &txb_ctx); + get_txb_ctx(plane_bsize, tx_size, plane, + pd->above_entropy_context + blk_col, + pd->left_entropy_context + blk_row, &txb_ctx); const int bwl = get_txb_bwl(tx_size); const int width = get_txb_wide(tx_size); const int height = get_txb_high(tx_size); @@ -2118,8 +2119,8 @@ eob_txb[block] = eob; if (eob == 0) { - av1_set_contexts(xd, pd, plane, plane_bsize, tx_size, 0, blk_col, - blk_row); + av1_set_entropy_contexts(xd, pd, plane, plane_bsize, tx_size, 0, blk_col, + blk_row); return; } const int segment_id = mbmi->segment_id; @@ -2220,8 +2221,8 @@ tcoeff = qcoeff; } const int cul_level = av1_get_txb_entropy_context(tcoeff, scan_order, eob); - av1_set_contexts(xd, pd, plane, plane_bsize, tx_size, cul_level, blk_col, - blk_row); + av1_set_entropy_contexts(xd, pd, plane, plane_bsize, tx_size, cul_level, + blk_col, blk_row); } void av1_update_txb_context(const AV1_COMP *cpi, ThreadData *td, @@ -2234,7 +2235,7 @@ MB_MODE_INFO *const mbmi = xd->mi[0]; struct tokenize_b_args arg = { cpi, td, 0, allow_update_cdf, dry_run }; if (mbmi->skip) { - av1_reset_skip_context(xd, bsize, num_planes); + av1_reset_entropy_context(xd, bsize, num_planes); return; }
diff --git a/av1/encoder/rd.c b/av1/encoder/rd.c index 727956c..21b75bd 100644 --- a/av1/encoder/rd.c +++ b/av1/encoder/rd.c
@@ -968,8 +968,8 @@ ENTROPY_CONTEXT t_left[MAX_MIB_SIZE]) { const int num_4x4_w = mi_size_wide[plane_bsize]; const int num_4x4_h = mi_size_high[plane_bsize]; - const ENTROPY_CONTEXT *const above = pd->above_context; - const ENTROPY_CONTEXT *const left = pd->left_context; + const ENTROPY_CONTEXT *const above = pd->above_entropy_context; + const ENTROPY_CONTEXT *const left = pd->left_entropy_context; memcpy(t_above, above, sizeof(ENTROPY_CONTEXT) * num_4x4_w); memcpy(t_left, left, sizeof(ENTROPY_CONTEXT) * num_4x4_h);
diff --git a/av1/encoder/tokenize.c b/av1/encoder/tokenize.c index eb57f88..e674153 100644 --- a/av1/encoder/tokenize.c +++ b/av1/encoder/tokenize.c
@@ -195,7 +195,7 @@ struct tokenize_b_args arg = { cpi, td, 0, allow_update_cdf, dry_run }; if (mbmi->skip) { - av1_reset_skip_context(xd, bsize, num_planes); + av1_reset_entropy_context(xd, bsize, num_planes); return; }