commit 67e15578bee52b52666759ad35a4fa7655d92957
author David Barker <david.barker@argondesign.com> Mon Jun 05 14:53:29 2017 +0100
committer Debargha Mukherjee <debargha@google.com> Mon Jun 12 17:08:27 2017 +0000
tree b87a2a64e405992caef43ac0c536faae79155e8c
parent b2c62bc7b62acd5dd66ba83b4efa650219ae2f55

Fix bug in loop-restoration unit tests

The values 'offset_r' and 'offset_c', representing a random
offset into a large pre-generated block, were calculated the
wrong way around. This could cause problems when testing
rectangular convolutions.

Change-Id: Ide830f275c83492abe83b61216da0fbce669fb7e

test/hiprec_convolve_test_util.cc

diff --git a/test/hiprec_convolve_test_util.cc b/test/hiprec_convolve_test_util.cc
index d53384c..f5661ec 100644
--- a/test/hiprec_convolve_test_util.cc
+++ b/test/hiprec_convolve_test_util.cc
@@ -92,8 +92,8 @@
 
   for (i = 0; i < num_iters; ++i) {
     // Choose random locations within the source block
-    int offset_r = 3 + rnd_.PseudoUniform(w - out_w - 7);
-    int offset_c = 3 + rnd_.PseudoUniform(h - out_h - 7);
+    int offset_r = 3 + rnd_.PseudoUniform(h - out_h - 7);
+    int offset_c = 3 + rnd_.PseudoUniform(w - out_w - 7);
     aom_convolve8_add_src_hip_c(input + offset_r * w + offset_c, w, output,
                                 out_w, hkernel, 16, vkernel, 16, out_w, out_h);
     test_impl(input + offset_r * w + offset_c, w, output2, out_w, hkernel, 16,
@@ -166,8 +166,8 @@
 
   for (i = 0; i < num_iters; ++i) {
     // Choose random locations within the source block
-    int offset_r = 3 + rnd_.PseudoUniform(w - out_w - 7);
-    int offset_c = 3 + rnd_.PseudoUniform(h - out_h - 7);
+    int offset_r = 3 + rnd_.PseudoUniform(h - out_h - 7);
+    int offset_c = 3 + rnd_.PseudoUniform(w - out_w - 7);
     aom_highbd_convolve8_add_src_hip_c(input_ptr + offset_r * w + offset_c, w,
                                        output_ptr, out_w, hkernel, 16, vkernel,
                                        16, out_w, out_h, bd);