commit 75a87844c0d9d3d169957bf1875cc8296d773301
author Johann <johann.koenig@duck.com> Tue Sep 25 11:06:09 2018 -0700
committer Johann Koenig <johannkoenig@google.com> Tue Sep 25 21:16:02 2018 +0000
tree fb4b10d348b70a85fda7e5c5e1a93d4045a7bc89
parent fb60e306121d650f78fe0d1cbad036a13c9d9e7c

loopfilter static analysis: limit plane_start/_end

static analysis runs through the loop with plane = 3 and generates a warning

Change-Id: Ic18608b6923bbc9547d033f3f1ce29b395c17c80

av1/common/av1_loopfilter.c

diff --git a/av1/common/av1_loopfilter.c b/av1/common/av1_loopfilter.c
index 0b2446f..b13f367 100644
--- a/av1/common/av1_loopfilter.c
+++ b/av1/common/av1_loopfilter.c
@@ -535,6 +535,9 @@
   filt_lvl_r[1] = cm->lf.filter_level_u;
   filt_lvl_r[2] = cm->lf.filter_level_v;
 
+  assert(plane_start >= AOM_PLANE_Y);
+  assert(plane_end <= MAX_MB_PLANE);
+
   for (plane = plane_start; plane < plane_end; plane++) {
     if (plane == 0 && !filt_lvl[0] && !filt_lvl_r[0])
       break;
@@ -546,7 +549,6 @@
     for (seg_id = 0; seg_id < MAX_SEGMENTS; seg_id++) {
       for (int dir = 0; dir < 2; ++dir) {
         int lvl_seg = (dir == 0) ? filt_lvl[plane] : filt_lvl_r[plane];
-        assert(plane >= 0 && plane <= 2);
         const int seg_lf_feature_id = seg_lvl_lf_lut[plane][dir];
         if (segfeature_active(seg, seg_id, seg_lf_feature_id)) {
           const int data = get_segdata(&cm->seg, seg_id, seg_lf_feature_id);