commit 7fe8cb729bf36264d47a5d5d1e1803fa2623d3c3
author Tom Finegan <tomfinegan@google.com> Mon Aug 06 11:53:40 2018 -0700
committer Tom Finegan <tomfinegan@google.com> Tue Aug 07 08:44:19 2018 -0700
tree 4860078db459107ed121ed4dea02e6dd8ae7d65b
parent 408fec56dd9166c8df2b25ab38f9a7398a71303a

cmake: Restrict exported symbols in shared object builds.

Add missing local section to linker script. Also some cosmetics:
- set() -> list(APPEND) in generate_exports.cmake.
- Make the linker script more readable (indent/whitespace).

BUG=aomedia:2072

Change-Id: I96d474f5ac9a7f9a19108cb9efd2af3587c9b81e

build/cmake/exports_sources.cmake

diff --git a/build/cmake/exports_sources.cmake b/build/cmake/exports_sources.cmake
index 74333bb..25ef104 100644
--- a/build/cmake/exports_sources.cmake
+++ b/build/cmake/exports_sources.cmake
@@ -13,19 +13,19 @@
 endif() # AOM_BUILD_CMAKE_EXPORTS_SOURCES_CMAKE_
 set(AOM_BUILD_CMAKE_EXPORTS_SOURCES_CMAKE_ 1)
 
-set(AOM_EXPORTS_SOURCES "${AOM_ROOT}/aom/exports_com")
+list(APPEND AOM_EXPORTS_SOURCES "${AOM_ROOT}/aom/exports_com")
 
 if(CONFIG_AV1_DECODER)
-  set(AOM_EXPORTS_SOURCES ${AOM_EXPORTS_SOURCES} "${AOM_ROOT}/aom/exports_dec"
-      "${AOM_ROOT}/av1/exports_dec")
+  list(APPEND AOM_EXPORTS_SOURCES "${AOM_ROOT}/aom/exports_dec"
+              "${AOM_ROOT}/av1/exports_dec")
 endif()
 
 if(CONFIG_AV1_ENCODER)
-  set(AOM_EXPORTS_SOURCES ${AOM_EXPORTS_SOURCES} "${AOM_ROOT}/aom/exports_enc"
-      "${AOM_ROOT}/av1/exports_enc")
+  list(APPEND AOM_EXPORTS_SOURCES "${AOM_ROOT}/aom/exports_enc"
+              "${AOM_ROOT}/av1/exports_enc")
 endif()
 
 if(ENABLE_TESTS)
-  set(AOM_EXPORTS_SOURCES ${AOM_EXPORTS_SOURCES} "${AOM_ROOT}/aom/exports_test"
-      "${AOM_ROOT}/av1/exports_test")
+  list(APPEND AOM_EXPORTS_SOURCES "${AOM_ROOT}/aom/exports_test"
+              "${AOM_ROOT}/av1/exports_test")
 endif()

build/cmake/generate_exports.cmake

diff --git a/build/cmake/generate_exports.cmake b/build/cmake/generate_exports.cmake
index 964804b..7ab5aae 100644
--- a/build/cmake/generate_exports.cmake
+++ b/build/cmake/generate_exports.cmake
@@ -36,7 +36,7 @@
 elseif("${AOM_TARGET_SYSTEM}" MATCHES "Windows\|MSYS" AND AOM_MSVC)
   file(WRITE "${aom_sym_file}" "LIBRARY aom\n" "EXPORTS\n")
 else()
-  file(WRITE "${aom_sym_file}" "{ global:\n")
+  file(WRITE "${aom_sym_file}" "{\nglobal:\n")
 endif()
 
 foreach(export_file ${AOM_EXPORTS_SOURCES})
@@ -57,10 +57,10 @@
     endif()
   endif()
   string(REGEX REPLACE "text \|data " "" "exported_symbol" "${exported_symbol}")
-  set(exported_symbol "${symbol_prefix}${exported_symbol}${symbol_suffix}")
+  set(exported_symbol "  ${symbol_prefix}${exported_symbol}${symbol_suffix}")
   file(APPEND "${aom_sym_file}" "${exported_symbol}\n")
 endforeach()
 
 if("${aom_sym_file}" MATCHES "ver$")
-  file(APPEND "${aom_sym_file}" " };")
+  file(APPEND "${aom_sym_file}" " \nlocal:\n  *;\n};")
 endif()