Refactor probability savings search.

- Avoid excessive copying
- Don't bother searching if no update can possibly offer savings
- Simplify the interface
- Remove the confusing av1_cost_upd256 macro

(cherry picked from libvpx/master commit
19e0b406c9601ec79f96cba654347e48650929ed)

Change-Id: Id9d9676a361fd1203b27e930cd29c23b2813ce59
diff --git a/av1/encoder/subexp.h b/av1/encoder/subexp.h
index d01dea9..9cd3c0b 100644
--- a/av1/encoder/subexp.h
+++ b/av1/encoder/subexp.h
@@ -29,7 +29,7 @@
                                         int probwt);
 
 int av1_prob_diff_update_savings_search_model(const unsigned int *ct,
-                                              const aom_prob *oldp,
+                                              const aom_prob oldp,
                                               aom_prob *bestp, aom_prob upd,
                                               int stepsize, int probwt);