commit cecdd73db786c2ea29f9d6eff1d30f1e8b75eeb5
author Fritz Koenig <frkoenig@google.com> Thu Jun 24 12:18:23 2010 -0400
committer Fritz Koenig <frkoenig@google.com> Thu Jun 24 12:18:23 2010 -0400
tree 445c822f06f2ffd580c17d3465ce7190dd17bae3
parent d1920de22cd6f13ba85b087ff06f6a8cfd4641d2

vp8cx : bestsad declared and initialized incorrectly.

bestsad should be an int initialized to INT_MAX.  The optimized
SAD function expects a signed value for bestsad to use for comparison
and early loop termination.  When no match is made, which is
determined by a comparison of bestsad to INT_MAX, INT_MAX is returned.

vp8/encoder/mcomp.c

diff --git a/vp8/encoder/mcomp.c b/vp8/encoder/mcomp.c
index 4c3edd7..6d69a9e 100644
--- a/vp8/encoder/mcomp.c
+++ b/vp8/encoder/mcomp.c
@@ -997,7 +997,7 @@
     int tot_steps;
     MV this_mv;
 
-    unsigned int bestsad = UINT_MAX;
+    int bestsad = INT_MAX;
     int best_site = 0;
     int last_site = 0;