commit d30cde5991b81166264e686538aebb13c77b25d2
author Debargha Mukherjee <debargha@google.com> Tue Mar 20 17:35:20 2018 -0700
committer Yaowu Xu <yaowu@google.com> Wed Mar 21 05:20:36 2018 +0000
tree 0a715c30c95d1cae2be1a7d9663ef47288aed935
parent 9fdc63fc91ae715f35d0550f44dd53f1dc550d68

[NORMATIVE] Set ref frame sign bias for S-frames

There is no need to disable setting reference frame
sign bias for S-frames. In the typical use-case for
S-frames, all reference frames will be past, but
there is no need to change the behavior normatively.

With this change, S-frames simply become short cuts
for the following higher level flags:
error_resilient_mode = 1,
frame_size_override_flag = 1,
refresh_frame_flags = 0xff.

BUG=aomedia:1629

Change-Id: Ib1b1926836d2bbdd7a5ca485c8b476e918b5de7e

av1/decoder/decodeframe.c

diff --git a/av1/decoder/decodeframe.c b/av1/decoder/decodeframe.c
index c1194e6..c15c9dc 100644
--- a/av1/decoder/decodeframe.c
+++ b/av1/decoder/decodeframe.c
@@ -2867,8 +2867,6 @@
         }
 #endif  // CONFIG_FRAME_REFS_SIGNALING
 
-        // NOTE: For the scenario of (cm->frame_type != S_FRAME),
-        // ref_frame_sign_bias will be reset based on frame offsets.
         cm->ref_frame_sign_bias[LAST_FRAME + i] = 0;
 
         if (cm->seq_params.frame_id_numbers_present_flag) {
@@ -2933,7 +2931,7 @@
 
   av1_setup_frame_buf_refs(cm);
 
-  if (!frame_is_sframe(cm)) av1_setup_frame_sign_bias(cm);
+  av1_setup_frame_sign_bias(cm);
 
   cm->cur_frame->intra_only = cm->frame_type == KEY_FRAME || cm->intra_only;
   cm->cur_frame->frame_type = cm->frame_type;