)]}'
{
  "commit": "de2ea94e30301c6df4ea511a3c8db5740eb26071",
  "tree": "f0d2bbd9c5aea70c87327c81f6c9863d05edca5e",
  "parents": [
    "724d31eb6e981e8359fcdbfb6c31ec05b3d9b032"
  ],
  "author": {
    "name": "Rupert Swarbrick",
    "email": "rupert.swarbrick@argondesign.com",
    "time": "Mon Oct 09 15:21:21 2017 +0100"
  },
  "committer": {
    "name": "Debargha Mukherjee",
    "email": "debargha@google.com",
    "time": "Tue Oct 10 00:49:02 2017 +0000"
  },
  "message": "Don\u0027t trash memory in select_tx_type_yrd\n\nThis patch fixes a bug in select_tx_type_yrd. The function works by\nlooping over possible transform types to find the best option (calling\nselect_tx_size_fix_type for each). Whenever there\u0027s a new best\ncandidate, the code copies information about the transform from the\nmbmi structure into stack-allocated \"best candidate\" structures. At\nthe end, it copies the \"best candidate\" data back to mbmi.\n\nBefore the patch, if ref_best_rd was small, each call to\nselect_tx_size_fix_type might return INT64_MAX (because they don\u0027t\nfind anything better than ref_best_rd) and so we\u0027d never actually copy\nanything to the \"best candidate\" structures. Then, at the end of the\nfunction, we\u0027d merrily overwrite mbmi with whatever happened to be on\nthe stack, causing general mayhem when something tried to read the\ndata from mbmi later.\n\nThis patch exits early if no candidates were found. It also adds an\nassertion saying that if no candidates were found, ref_best_rd must\nhave been less than INT64_MAX. This should hopefully catch any bugs\nwhere the continue keywords in the loop stop us ever actually calling\nselect_tx_size_fix_type.\n\nChange-Id: I54b998148281dd80f98d1570f736964593dc753f\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "63d34dc4129d897345931180ebf88c2cf3ac4907",
      "old_mode": 33188,
      "old_path": "av1/encoder/rdopt.c",
      "new_id": "11134b0c2fd0fb614a4d5ff178bdc53a031dc429",
      "new_mode": 33188,
      "new_path": "av1/encoder/rdopt.c"
    }
  ]
}