)]}'
{
  "commit": "e63182c41f723ef549e5c324d00146ddacd7d84c",
  "tree": "86a3f0b4155f0afb84f53581c8102bfe62c0bf88",
  "parents": [
    "15f9e4b5ca3175616c5f98b869835ea4b679178e"
  ],
  "author": {
    "name": "Wan-Teh Chang",
    "email": "wtc@google.com",
    "time": "Sun Mar 29 08:43:13 2020 -0700"
  },
  "committer": {
    "name": "Yaowu Xu",
    "email": "yaowu@google.com",
    "time": "Mon Mar 30 14:24:19 2020 +0000"
  },
  "message": "Change v256_ssd_s16_sum() to return uint64_t.\n\nFix the Visual Studio 2015 and 2017 compiler warning:\n  aom_dsp\\simd/v256_intrinsics.h(93,31): warning C4244: \u0027return\u0027:\n  conversion from \u0027uint64_t\u0027 to \u0027uint32_t\u0027, possible loss of data\n\nEvidences that v256_ssd_s16_sum() should return uint64_t:\n\n1. The other two implementations of this function both return uint64_t.\n\n  aom_dsp/simd/v256_intrinsics_v128.h:\n  SIMD_INLINE uint64_t v256_ssd_s16_sum(ssd256_internal_s16 s) {\n    return v128_ssd_s16_sum(s.val[1]) + v128_ssd_s16_sum(s.val[0]);\n  }\n\n  aom_dsp/simd/v256_intrinsics_x86.h:\n  SIMD_INLINE uint64_t v256_ssd_s16_sum(ssd256_internal_s16 s) {\n    v128 t \u003d v128_add_64(v256_high_v128(s), v256_low_v128(s));\n    return v64_u64(v128_low_v64(t)) + v64_u64(v128_high_v64(t));\n  }\n\n2. The unit test apparently expects this function to return uint64_t.\n\n  test/simd_cmp_impl.h:\n  uint64_t v256_ssd_s16(v256 a, v256 b) {\n    return v256_ssd_s16_sum(::v256_ssd_s16(v256_ssd_s16_init(), a, b));\n  }\n\nChange-Id: I0d2dba93cbdd95bdd61c273036086979fc6e3a96\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "1edbb383d72148db30d4cb6785c0288965e8a287",
      "old_mode": 33188,
      "old_path": "aom_dsp/simd/v256_intrinsics.h",
      "new_id": "17e36eed61d88f9b044bb0f7cfe890f35820c276",
      "new_mode": 33188,
      "new_path": "aom_dsp/simd/v256_intrinsics.h"
    }
  ]
}