commit e74099f092043b07bae7b7429fbda240c6646019
author Wan-Teh Chang <wtc@google.com> Wed May 23 14:57:35 2018 -0700
committer Wan-Teh Chang <wtc@google.com> Thu May 24 21:08:18 2018 +0000
tree 31752d7972be934b204b57da214e31acf1de4d60
parent 6a26b0c3c83d73dbf30cee04caf93ebc45244234

Initialize the is_annexb field of stream_info.

It seems bad to set is_annexb to the hardcoded value of 0, but that's
still better than leaving it uninitialized.

Improve the comment for the in/out 'si' argument of
aom_codec_peek_stream_info() and aom_codec_peek_si_fn_t. Specifically,
document which fields of the 'si' argument are treated as inputs and
which fields are treated as outputs.

BUG=aomedia:1901

Change-Id: Ib3657e22b81e3a0d34f83a706caacb9455dcf13b

aom/aom_decoder.h

diff --git a/aom/aom_decoder.h b/aom/aom_decoder.h
index b16ca29..3bbdcd7 100644
--- a/aom/aom_decoder.h
+++ b/aom/aom_decoder.h
@@ -151,7 +151,9 @@
  * \param[in]      iface   Pointer to the algorithm interface
  * \param[in]      data    Pointer to a block of data to parse
  * \param[in]      data_sz Size of the data buffer
- * \param[in,out]  si      Pointer to stream info to update.
+ * \param[in,out]  si      Pointer to stream info to update. The is_annexb
+ *                         member \ref MUST be properly initialized. This
+ *                         function sets the rest of the members.
  *
  * \retval #AOM_CODEC_OK
  *     Bitstream is parsable and stream information updated.

aom/internal/aom_codec_internal.h

diff --git a/aom/internal/aom_codec_internal.h b/aom/internal/aom_codec_internal.h
index a937e0e..84ea4ee 100644
--- a/aom/internal/aom_codec_internal.h
+++ b/aom/internal/aom_codec_internal.h
@@ -104,7 +104,9 @@
  *
  * \param[in]      data    Pointer to a block of data to parse
  * \param[in]      data_sz Size of the data buffer
- * \param[in,out]  si      Pointer to stream info to update
+ * \param[in,out]  si      Pointer to stream info to update. The is_annexb
+ *                         member \ref MUST be properly initialized. This
+ *                         function sets the rest of the members.
  *
  * \retval #AOM_CODEC_OK
  *     Bitstream is parsable and stream information updated

test/decode_test_driver.cc

diff --git a/test/decode_test_driver.cc b/test/decode_test_driver.cc
index d38ee92..9983c1f 100644
--- a/test/decode_test_driver.cc
+++ b/test/decode_test_driver.cc
@@ -65,6 +65,8 @@
     PreDecodeFrameHook(*video, decoder);
 
     aom_codec_stream_info_t stream_info;
+    stream_info.is_annexb = 0;
+
     if (video->cxdata() != NULL) {
       const aom_codec_err_t res_peek = decoder->PeekStream(
           video->cxdata(), video->frame_size(), &stream_info);