Fix some clang warnings (#448)
Fix some clang warnings
- Disable `-Wused-but-marked-unused` on Clang on MINGW. This solves #435.
I created an issue but didn't get response from MINGW maintainers for a week, so for now just disable the warning in this case.
- Remove extra semicolon in `codec_svt.c`. This fixes `-Wextra-semi-stmt` warning.
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1a4f501..7b3fce2 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -137,6 +137,12 @@
if(HAVE_POISON_SYSTEM_DIRECTORIES_WARNING)
add_definitions(-Wno-poison-system-directories)
endif()
+ # MINGW declares printf with __attribute__ ((__unused__)) in stdio.h.
+ # It is out of our control so we just ignore it.
+ # See https://sourceforge.net/p/mingw-w64/bugs/868/
+ if(MINGW)
+ add_definitions(-Wno-used-but-marked-unused)
+ endif()
elseif(CMAKE_C_COMPILER_ID MATCHES "GNU")
MESSAGE(STATUS "libavif: Enabling warnings for GCC")
add_definitions(-Wall -Wextra)
diff --git a/src/codec_svt.c b/src/codec_svt.c
index 434dae1..0457950 100644
--- a/src/codec_svt.c
+++ b/src/codec_svt.c
@@ -11,7 +11,7 @@
#define STR_HELPER(x) #x
#define STR(x) STR_HELPER(x)
-#define SVT_FULL_VERSION STR(SVT_VERSION_MAJOR) "." STR(SVT_VERSION_MINOR) "." STR(SVT_VERSION_PATCHLEVEL);
+#define SVT_FULL_VERSION STR(SVT_VERSION_MAJOR) "." STR(SVT_VERSION_MINOR) "." STR(SVT_VERSION_PATCHLEVEL)
typedef struct avifCodecInternal
{
