commit 01884e42832ba2bc0c6921b3e3d22aa71fe9cda2
author Wan-Teh Chang <wtc@google.com> Mon Apr 27 17:33:04 2020 -0700
committer Joe Drago <joedrago@gmail.com> Mon Apr 27 22:32:59 2020 -0700
tree 11bda4f56bd861e8110ea53a1ed723309aad3da1
parent 2077af898c30c7defd7bcc415762edc4502cdbbe

Improve output file extension error handling.

AVIF_APP_FILE_FORMAT_UNKNOWN should result in an error message and error
exit status.

Print outputFilename, not inputFilename, in error messages.

apps/avifdec.c

diff --git a/apps/avifdec.c b/apps/avifdec.c
index 8f3a266..e0468ad 100644
--- a/apps/avifdec.c
+++ b/apps/avifdec.c
@@ -142,6 +142,8 @@
 
         avifAppFileFormat outputFormat = avifGuessFileFormat(outputFilename);
         if (outputFormat == AVIF_APP_FILE_FORMAT_UNKNOWN) {
+            fprintf(stderr, "Cannot determine output file extension: %s\n", outputFilename);
+            returnCode = 1;
         } else if (outputFormat == AVIF_APP_FILE_FORMAT_Y4M) {
             if (!y4mWrite(avif, outputFilename)) {
                 returnCode = 1;
@@ -155,7 +157,7 @@
                 returnCode = 1;
             }
         } else {
-            fprintf(stderr, "Unrecognized file extension: %s\n", inputFilename);
+            fprintf(stderr, "Unrecognized file extension: %s\n", outputFilename);
             returnCode = 1;
         }
     } else {