commit 0261bb728c9a92570282255326c201b050d4da93
author Joe Drago <jdrago@netflix.com> Wed Sep 25 13:50:06 2019 -0700
committer Joe Drago <jdrago@netflix.com> Wed Sep 25 13:50:06 2019 -0700
tree c0e110f3017369dba5588965c30966eb0cd37401
parent 345aaa1d003b95064d735c6ea59ab723cedb82a2

Fix a few clang/macOS warnings

CHANGELOG.md

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 80ed04d..2edcc7e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@
 ## [Unreleased]
 ### Changed
 - Split avifRawData and avifStream into read-only (const) and read/write versions, updated code accordingly
+- Fix a few clang/macOS warnings
 
 ## [0.3.8] - 2019-09-04
 ### Changed

apps/avifdec.c

diff --git a/apps/avifdec.c b/apps/avifdec.c
index 24007af..f5dbc27 100644
--- a/apps/avifdec.c
+++ b/apps/avifdec.c
@@ -9,7 +9,7 @@
 #include <stdio.h>
 #include <string.h>
 
-int syntax(void)
+static int syntax(void)
 {
     printf("Syntax: avifdec [options] input.avif output.y4m\n");
     printf("Options:\n");

apps/shared/y4m.c

diff --git a/apps/shared/y4m.c b/apps/shared/y4m.c
index e722ccf..e326019 100644
--- a/apps/shared/y4m.c
+++ b/apps/shared/y4m.c
@@ -9,7 +9,7 @@
 #include <stdlib.h>
 #include <string.h>
 
-avifBool y4mColorSpaceToFormatAndDepth(const char * formatString, avifPixelFormat * format, int * depth)
+static avifBool y4mColorSpaceToFormatAndDepth(const char * formatString, avifPixelFormat * format, int * depth)
 {
     if (!strcmp(formatString, "C420jpeg")) {
         *format = AVIF_PIXEL_FORMAT_YUV420;
@@ -74,7 +74,7 @@
     return AVIF_FALSE;
 }
 
-avifBool getHeaderString(uint8_t * p, uint8_t * end, char * out, size_t maxChars)
+static avifBool getHeaderString(uint8_t * p, uint8_t * end, char * out, size_t maxChars)
 {
     uint8_t * headerEnd = p;
     while ((*headerEnd != ' ') && (*headerEnd != '\n')) {
@@ -227,7 +227,7 @@
     avif->height = height;
     avif->depth = depth;
     avif->yuvFormat = format;
-    avif->yuvRange = rangeFlag;
+    avif->yuvRange = (uint8_t)rangeFlag;
     avifImageAllocatePlanes(avif, AVIF_PLANES_YUV);
 
     avifPixelFormatInfo info;

src/codec_dav1d.c

diff --git a/src/codec_dav1d.c b/src/codec_dav1d.c
index 4cc2da8..b48c10f 100644
--- a/src/codec_dav1d.c
+++ b/src/codec_dav1d.c
@@ -151,7 +151,7 @@
             nclx.colourPrimaries = (uint16_t)dav1dImage->seq_hdr->pri;
             nclx.transferCharacteristics = (uint16_t)dav1dImage->seq_hdr->trc;
             nclx.matrixCoefficients = (uint16_t)dav1dImage->seq_hdr->mtrx;
-            nclx.fullRangeFlag = image->yuvRange;
+            nclx.fullRangeFlag = (uint8_t)image->yuvRange;
             avifImageSetProfileNCLX(image, &nclx);
         }
 

tests/aviffuzz.c

diff --git a/tests/aviffuzz.c b/tests/aviffuzz.c
index 326e0db..01c5365 100644
--- a/tests/aviffuzz.c
+++ b/tests/aviffuzz.c
@@ -6,12 +6,6 @@
 #include <stdio.h>
 #include <string.h>
 
-int syntax(void)
-{
-    printf("Syntax: aviffuzz input.avif\n");
-    return 0;
-}
-
 int main(int argc, char * argv[])
 {
     const char * inputFilename = NULL;