commit 17d7cbb9c432901f83a5e5df9361e374fdfb092b
author Frankie Dintino <fdintino@gmail.com> Fri Sep 29 20:54:55 2023 +0000
committer GitHub <noreply@github.com> Fri Sep 29 22:54:55 2023 +0200
tree 89f2c20c96b6c7fdfc8929676ec83f924c3946b0
parent ce026241b3ba8240d615019e17469d6aa4f455de

fix: unused parameter error in third_party libyuv with release build  (#1634)

fix: unused parameter error in third_party libyuv with release build

In several functions in libyuv/scale.c, the only reference to the
parameter `src_width` is an assert statement. When NDEBUG is defined (as
it is on some platforms when compiling with CMAKE_BUILD_TYPE=Release)
the assert condition is removed from the source and an unused-parameter
warning/error is raised.

.github/workflows/ci-unix-shared-local.yml

diff --git a/.github/workflows/ci-unix-shared-local.yml b/.github/workflows/ci-unix-shared-local.yml
index 97d5ac4..cc8e374 100644
--- a/.github/workflows/ci-unix-shared-local.yml
+++ b/.github/workflows/ci-unix-shared-local.yml
@@ -21,6 +21,9 @@
       fail-fast: false
       matrix:
         os: [ubuntu-latest, macos-latest]
+        libyuv: [ON, OFF]
+
+    name: build-shared-local (${{ matrix.os }}, libyuv ${{ matrix.libyuv }})
 
     steps:
     - uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac # v4.0.0
@@ -89,7 +92,7 @@
         -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=ON
         -DAVIF_CODEC_AOM=ON -DAVIF_LOCAL_AOM=ON
         -DAVIF_CODEC_DAV1D=ON -DAVIF_LOCAL_DAV1D=ON
-        -DAVIF_LOCAL_LIBYUV=ON
+        -DAVIF_LOCAL_LIBYUV=${{ matrix.libyuv }}
         -DAVIF_LOCAL_LIBSHARPYUV=ON
         -DAVIF_BUILD_EXAMPLES=ON -DAVIF_BUILD_APPS=ON
         -DAVIF_BUILD_TESTS=ON -DAVIF_ENABLE_GTEST=ON -DAVIF_LOCAL_GTEST=ON

third_party/libyuv/source/scale.c

diff --git a/third_party/libyuv/source/scale.c b/third_party/libyuv/source/scale.c
index 87e5e0c..1991369 100644
--- a/third_party/libyuv/source/scale.c
+++ b/third_party/libyuv/source/scale.c
@@ -465,6 +465,7 @@
   int y;
   int dy;
 
+  (void)src_width;
   // This function can only scale up by 2 times horizontally.
   assert(src_width == ((dst_width + 1) / 2));
 
@@ -499,6 +500,7 @@
       ScaleRowUp2_Bilinear_Any_C;
   int x;
 
+  (void)src_width;
   // This function can only scale up by 2 times.
   assert(src_width == ((dst_width + 1) / 2));
   assert(src_height == ((dst_height + 1) / 2));
@@ -536,6 +538,7 @@
   int y;
   int dy;
 
+  (void)src_width;
   // This function can only scale up by 2 times horizontally.
   assert(src_width == ((dst_width + 1) / 2));
 
@@ -571,6 +574,7 @@
       ScaleRowUp2_Bilinear_16_Any_C;
   int x;
 
+  (void)src_width;
   // This function can only scale up by 2 times.
   assert(src_width == ((dst_width + 1) / 2));
   assert(src_height == ((dst_height + 1) / 2));
@@ -601,6 +605,7 @@
   int y;
   int dy;
 
+  (void)src_width;
   // This function can only scale up by 2 times horizontally.
   assert(src_width == ((dst_width + 1) / 2));
 
@@ -631,6 +636,7 @@
       ScaleRowUp2_Bilinear_16_Any_C;
   int x;
 
+  (void)src_width;
   // This function can only scale up by 2 times.
   assert(src_width == ((dst_width + 1) / 2));
   assert(src_height == ((dst_height + 1) / 2));