commit 21961f41f5605e96a5a5a4bed88d899131102a7a
author Wan-Teh Chang <wtc@google.com> Mon Mar 14 16:25:44 2022 -0700
committer Wan-Teh Chang <wtc@google.com> Tue Mar 15 08:45:55 2022 -0700
tree a8a0dc88fee56c4800b5c2cce4cdb95db48e690d
parent a3198935f91f2eeeaba9f0eb8f63374add48526a

Replace some memcpy calls with struct assignments

An advantage of struct assignments is that the compiler does type
checking. It will also avoid the potential mistake of passing an
incorrect third argument to memcpy().

To avoid conflict with a pending pull request, this pull request does
not change src/read.c.

src/write.c

diff --git a/src/write.c b/src/write.c
index f8180a6..ad05931 100644
--- a/src/write.c
+++ b/src/write.c
@@ -880,7 +880,7 @@
             const avifEncodeSample * firstSample = &item->encodeOutput->samples.sample[0];
             avifSequenceHeader sequenceHeader;
             if (avifSequenceHeaderParse(&sequenceHeader, (const avifROData *)&firstSample->data)) {
-                memcpy(&item->av1C, &sequenceHeader.av1C, sizeof(avifCodecConfigurationBox));
+                item->av1C = sequenceHeader.av1C;
             } else {
                 // This must be an invalid AV1 payload
                 return item->alpha ? AVIF_RESULT_ENCODE_ALPHA_FAILED : AVIF_RESULT_ENCODE_COLOR_FAILED;
@@ -1085,7 +1085,7 @@
                 avifEncoderItem * dedupItem = &encoder->data->items.item[dedupIndex];
                 if (item->dimgFromID == dedupItem->dimgFromID) {
                     // We've already written dedup's items out. Steal their ipma indices and move on!
-                    memcpy(&item->ipma, &dedupItem->ipma, sizeof(struct ipmaArray));
+                    item->ipma = dedupItem->ipma;
                     foundPreviousCell = AVIF_TRUE;
                     break;
                 }