commit 341a6a6b62574f99247e98aebaca9095febdfc19
author Joe Drago <jdrago@netflix.com> Tue Jul 23 16:12:59 2019 -0700
committer Joe Drago <jdrago@netflix.com> Tue Jul 23 16:12:59 2019 -0700
tree 411e3a9dd1ce7bb4fff0ee4517c37e2cb9451ee9
parent 25dd4788438e05cd0bfec8ae4f276a060cec059a

Enabled tons of warnings, and warnings-as-errors; Fixed associated fallout

src/read.c

diff --git a/src/read.c b/src/read.c
index 63f085d..cb979b4 100644
--- a/src/read.c
+++ b/src/read.c
@@ -320,9 +320,11 @@
 // ---------------------------------------------------------------------------
 // BMFF Parsing
 
-#define BEGIN_STREAM(VARNAME, PTR, SIZE)           \
-    avifStream VARNAME;                            \
-    avifRawData VARNAME##_rawData = { PTR, SIZE }; \
+#define BEGIN_STREAM(VARNAME, PTR, SIZE) \
+    avifStream VARNAME;                  \
+    avifRawData VARNAME##_rawData;       \
+    VARNAME##_rawData.data = PTR;        \
+    VARNAME##_rawData.size = SIZE;       \
     avifStreamStart(&VARNAME, &VARNAME##_rawData)
 
 static avifBool avifParseItemLocationBox(avifData * data, uint8_t * raw, size_t rawLen)
@@ -1350,15 +1352,15 @@
         // Naughty! Alpha planes are supposed to be full range. Correct that here.
         avifImageCopyDecoderAlpha(decoder->image);
         if (avifImageUsesU16(decoder->image)) {
-            for (int j = 0; j < decoder->image->height; ++j) {
-                for (int i = 0; i < decoder->image->height; ++i) {
+            for (uint32_t j = 0; j < decoder->image->height; ++j) {
+                for (uint32_t i = 0; i < decoder->image->height; ++i) {
                     uint16_t * alpha = (uint16_t *)&decoder->image->alphaPlane[(i * 2) + (j * decoder->image->alphaRowBytes)];
                     *alpha = (uint16_t)avifLimitedToFullY(decoder->image->depth, *alpha);
                 }
             }
         } else {
-            for (int j = 0; j < decoder->image->height; ++j) {
-                for (int i = 0; i < decoder->image->height; ++i) {
+            for (uint32_t j = 0; j < decoder->image->height; ++j) {
+                for (uint32_t i = 0; i < decoder->image->height; ++i) {
                     uint8_t * alpha = &decoder->image->alphaPlane[i + (j * decoder->image->alphaRowBytes)];
                     *alpha = (uint8_t)avifLimitedToFullY(decoder->image->depth, *alpha);
                 }