commit 37ff3889b7b0b4ca34d708dc5bb5d0ef240d821d
author Wan-Teh Chang <wtc@google.com> Mon Oct 06 14:31:27 2025 -0700
committer Wan-Teh Chang <wtc@google.com> Mon Oct 06 15:33:14 2025 -0700
tree 1cf23e04c04167e329b8ad02a8e63f8fbe178b34
parent 40cb2c1fbff1e14b6c81816b73a364490b12ffb6

Check creationTime only if LLONG_MAX > UINT64_MAX

If LLONG_MAX <= UINT64_MAX, creationTime > UINT64_MAX is always false
regardless of the value of creationTime. So only check creationTime if
LLONG_MAX > UINT64_MAX.

Similarly for modificationTime.

Fix Coverity CID 549268 and CID 549269: Operands don't affect result
(CONSTANT_EXPRESSION_RESULT).

apps/avifenc.c

diff --git a/apps/avifenc.c b/apps/avifenc.c
index fefac66..79c185d 100644
--- a/apps/avifenc.c
+++ b/apps/avifenc.c
@@ -10,6 +10,7 @@
 
 #include <assert.h>
 #include <inttypes.h>
+#include <limits.h>
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
@@ -1910,18 +1911,30 @@
         } else if (!strcmp(arg, "--creation-time")) {
             NEXTARG();
             long long creationTime = strtoll(arg, NULL, 0);
-            if (creationTime < 0 || (unsigned long long)creationTime > UINT64_MAX) {
+            if (creationTime < 0) {
                 fprintf(stderr, "ERROR: Invalid creation time: %lld\n", creationTime);
                 goto cleanup;
             }
+#if LLONG_MAX > UINT64_MAX
+            if ((unsigned long long)creationTime > UINT64_MAX) {
+                fprintf(stderr, "ERROR: Invalid creation time: %lld\n", creationTime);
+                goto cleanup;
+            }
+#endif
             settings.creationTime = (uint64_t)creationTime;
         } else if (!strcmp(arg, "--modification-time")) {
             NEXTARG();
             long long modificationTime = strtoll(arg, NULL, 0);
-            if (modificationTime < 0 || (unsigned long long)modificationTime > UINT64_MAX) {
+            if (modificationTime < 0) {
                 fprintf(stderr, "ERROR: Invalid modification time: %lld\n", modificationTime);
                 goto cleanup;
             }
+#if LLONG_MAX > UINT64_MAX
+            if ((unsigned long long)modificationTime > UINT64_MAX) {
+                fprintf(stderr, "ERROR: Invalid modification time: %lld\n", modificationTime);
+                goto cleanup;
+            }
+#endif
             settings.modificationTime = (uint64_t)modificationTime;
         } else if (!strcmp(arg, "-c") || !strcmp(arg, "--codec")) {
             NEXTARG();