commit 5572e9c915ee6f02da36379a9e34ab8649740742
author Vignesh Venkat <vigneshv@google.com> Thu Mar 27 11:45:42 2025 -0700
committer Vignesh Venkatasubramanian <vigneshvg@users.noreply.github.com> Fri Mar 28 09:26:46 2025 -0700
tree 2aa93690026bfd66e92e3734709b77db427bc5e3
parent 98cd3817d56d24299a99a6fae7a5c1b633bc002d

read: Fix some return values

`AVIF_FALSE` is being returned from some functions which return
`avifResult`. `AVIF_FALSE` is `0` which translates to
`AVIF_RESULT_OK` when (accidentally) converted to `avifResult`
which is incorrect.

I think this was a copy-paste error from functions which were
previously returning `avifBool`.

src/read.c

diff --git a/src/read.c b/src/read.c
index 61def99..88b9942 100644
--- a/src/read.c
+++ b/src/read.c
@@ -3390,7 +3390,7 @@
                 //   The handler type for the MetaBox shall be 'pict'.
                 if (memcmp(handlerType, "pict", 4) != 0) {
                     avifDiagnosticsPrintf(diag, "Box[hdlr] handler_type is not 'pict'");
-                    return AVIF_FALSE;
+                    return AVIF_RESULT_BMFF_PARSE_FAILED;
                 }
                 firstBox = AVIF_FALSE;
             } else {
@@ -3958,7 +3958,7 @@
                 !memcmp(track->handlerType, "auxv", 4)) {
                 if ((track->width == 0) || (track->height == 0)) {
                     avifDiagnosticsPrintf(data->diag, "Track ID [%u] has an invalid size [%ux%u]", track->id, track->width, track->height);
-                    return AVIF_FALSE;
+                    return AVIF_RESULT_BMFF_PARSE_FAILED;
                 }
                 if (avifDimensionsTooLarge(track->width, track->height, imageSizeLimit, imageDimensionLimit)) {
                     avifDiagnosticsPrintf(data->diag,
@@ -3966,7 +3966,7 @@
                                           track->id,
                                           track->width,
                                           track->height);
-                    return AVIF_FALSE;
+                    return AVIF_RESULT_BMFF_PARSE_FAILED;
                 }
             }
         }