commit 573815bc337f8b09100d1fc4bc4f30ed7a0c0d9d
author Wan-Teh Chang <wtc@google.com> Tue Jun 08 17:00:57 2021 -0700
committer Joe Drago <joedrago@gmail.com> Tue Jun 08 17:06:08 2021 -0700
tree 7d940e222c731c4fda9cf4dbed5d83610cc93b42
parent 5e8cb669701672bea1f2f683fb07ce6915a69972

Cleanup related to avifDiagnosticsClearError()

1. Have avifCropRectConvertCleanApertureBox() and
avifCleanApertureBoxConvertCropRect() call avifDiagnosticsClearError()
on entry.

2. avifDiagnosticsClearError() just needs to set the first character of
the diag->error buffer to '\0' rather than memset the entire buffer.

src/avif.c

diff --git a/src/avif.c b/src/avif.c
index bc238f2..0fa17aa 100644
--- a/src/avif.c
+++ b/src/avif.c
@@ -543,6 +543,8 @@
                                              avifPixelFormat yuvFormat,
                                              avifDiagnostics * diag)
 {
+    avifDiagnosticsClearError(diag);
+
     // ISO/IEC 14496-12:2020, Section 12.1.4.1:
     //   For horizOff and vertOff, D shall be strictly positive and N may be
     //   positive or negative. For cleanApertureWidth and cleanApertureHeight,
@@ -646,6 +648,8 @@
                                              avifPixelFormat yuvFormat,
                                              avifDiagnostics * diag)
 {
+    avifDiagnosticsClearError(diag);
+
     if (!avifCropRectIsValid(cropRect, imageW, imageH, yuvFormat, diag)) {
         return AVIF_FALSE;
     }

src/diag.c

diff --git a/src/diag.c b/src/diag.c
index 49c1ac8..d97be9b 100644
--- a/src/diag.c
+++ b/src/diag.c
@@ -9,7 +9,7 @@
 
 void avifDiagnosticsClearError(avifDiagnostics * diag)
 {
-    memset(diag->error, 0, AVIF_DIAGNOSTICS_ERROR_BUFFER_SIZE);
+    *diag->error = '\0';
 }
 
 #ifdef __clang__