commit 9ece9c7fdf4e8790f8d03b33f675f63ee8d08184
author Wan-Teh Chang <wtc@google.com> Fri Jun 28 15:23:28 2024 -0700
committer Wan-Teh Chang <wtc@google.com> Mon Jul 01 10:57:15 2024 -0700
tree ae8db3ac44f2c8b6fcba4484f3d0bcdffbbd02d1
parent c5693f7481f08ebfa951311875cd8d5b1fae69ef

Print boxFourcc & configPropName using %.4s format

avifParseCodecConfiguration() should not assume the configPropName
parameter is a null-terminated string.

src/read.c

diff --git a/src/read.c b/src/read.c
index adbd5e9..7e53e72 100644
--- a/src/read.c
+++ b/src/read.c
@@ -788,7 +788,7 @@
 static avifResult avifCheckItemID(const char * boxFourcc, uint32_t itemID, avifDiagnostics * diag)
 {
     if (itemID == 0) {
-        avifDiagnosticsPrintf(diag, "Box[%4s] has an invalid item ID [%u]", boxFourcc, itemID);
+        avifDiagnosticsPrintf(diag, "Box[%.4s] has an invalid item ID [%u]", boxFourcc, itemID);
         return AVIF_RESULT_BMFF_PARSE_FAILED;
     }
     return AVIF_RESULT_OK;
@@ -2261,12 +2261,12 @@
     uint32_t marker, version;
     AVIF_CHECK(avifROStreamReadBits(s, &marker, /*bitCount=*/1)); // unsigned int (1) marker = 1;
     if (!marker) {
-        avifDiagnosticsPrintf(diag, "%s contains illegal marker: [%u]", configPropName, marker);
+        avifDiagnosticsPrintf(diag, "%.4s contains illegal marker: [%u]", configPropName, marker);
         return AVIF_FALSE;
     }
     AVIF_CHECK(avifROStreamReadBits(s, &version, /*bitCount=*/7)); // unsigned int (7) version = 1;
     if (version != 1) {
-        avifDiagnosticsPrintf(diag, "%s contains illegal version: [%u]", configPropName, version);
+        avifDiagnosticsPrintf(diag, "%.4s contains illegal version: [%u]", configPropName, version);
         return AVIF_FALSE;
     }