commit b69a32931e6684522db3b2ef79d09cfc67ff2a61
author Wan-Teh Chang <wtc@google.com> Mon Oct 12 20:38:56 2020 -0700
committer Joe Drago <joedrago@gmail.com> Tue Oct 13 09:05:35 2020 -0700
tree 1dd4ef5fbcca6225aa3e52b1f535cdc3c7957d94
parent e67f9369d50e00c59b504abf52655b3c0f304430

avifIO read() should require readFlags == 0

Since no read flags are defined yet, current implementations of
avifIOReadFunc should require the readFlags parameter be 0.

src/io.c

diff --git a/src/io.c b/src/io.c
index 9f9a03b..341f29d 100644
--- a/src/io.c
+++ b/src/io.c
@@ -27,7 +27,10 @@
 {
     // printf("avifIOMemoryReaderRead offset %" PRIu64 " size %zu\n", offset, size);
 
-    (void)readFlags;
+    if (readFlags != 0) {
+        // Unsupported readFlags
+        return AVIF_RESULT_IO_ERROR;
+    }
 
     avifIOMemoryReader * reader = (avifIOMemoryReader *)io;
 
@@ -78,7 +81,10 @@
 {
     // printf("avifIOFileReaderRead offset %" PRIu64 " size %zu\n", offset, size);
 
-    (void)readFlags;
+    if (readFlags != 0) {
+        // Unsupported readFlags
+        return AVIF_RESULT_IO_ERROR;
+    }
 
     avifIOFileReader * reader = (avifIOFileReader *)io;
 

tests/aviftest.c

diff --git a/tests/aviftest.c b/tests/aviftest.c
index 5301f5b..d7bdea6 100644
--- a/tests/aviftest.c
+++ b/tests/aviftest.c
@@ -265,7 +265,10 @@
 {
     // printf("avifIOTestReaderRead offset %" PRIu64 " size %zu\n", offset, size);
 
-    (void)readFlags;
+    if (readFlags != 0) {
+        // Unsupported readFlags
+        return AVIF_RESULT_IO_ERROR;
+    }
 
     avifIOTestReader * reader = (avifIOTestReader *)io;