commit e184dc1d28a52ed18b8d9cdad3fbb5e3bd07f8c7
author Wan-Teh Chang <wtc@google.com> Mon May 11 12:47:21 2020 -0700
committer Joe Drago <joedrago@gmail.com> Mon May 11 13:07:36 2020 -0700
tree 9bb4a0e3c0ad6dfb3a6e8ae5cd84500e7157b8e0
parent 67b2ff767096350d256d783aa0394ca9b7cec01c

Add 'const' to some pointer parameters

I made a pass through the public header avif.h and added 'const' to the
pointer parameters that could be declared as 'const'. I then made the
necessary changes to make the code compile.

src/write.c

diff --git a/src/write.c b/src/write.c
index 37f9a9d..dc0b5d2 100644
--- a/src/write.c
+++ b/src/write.c
@@ -25,8 +25,8 @@
 static const char xmpContentType[] = CONTENT_TYPE_XMP;
 static const size_t xmpContentTypeSize = sizeof(xmpContentType);
 
-static avifBool avifImageIsOpaque(avifImage * image);
-static void fillConfigBox(avifCodec * codec, avifImage * image, avifBool alpha);
+static avifBool avifImageIsOpaque(const avifImage * image);
+static void fillConfigBox(avifCodec * codec, const avifImage * image, avifBool alpha);
 static void writeConfigBox(avifRWStream * s, avifCodecConfigurationBox * cfg);
 
 // ---------------------------------------------------------------------------
@@ -37,9 +37,9 @@
 {
     uint16_t id;
     uint8_t type[4];
-    avifImage * image;  // avifImage* to use when encoding or populating ipma for this item (unowned)
-    avifCodec * codec;  // only present on type==av01
-    avifRWData content; // OBU data on av01, metadata payload for Exif/XMP
+    const avifImage * image; // avifImage* to use when encoding or populating ipma for this item (unowned)
+    avifCodec * codec;       // only present on type==av01
+    avifRWData content;      // OBU data on av01, metadata payload for Exif/XMP
     avifBool alpha;
 
     const char * infeName;
@@ -121,7 +121,7 @@
     avifFree(encoder);
 }
 
-avifResult avifEncoderWrite(avifEncoder * encoder, avifImage * image, avifRWData * output)
+avifResult avifEncoderWrite(avifEncoder * encoder, const avifImage * image, avifRWData * output)
 {
     if ((image->depth != 8) && (image->depth != 10) && (image->depth != 12)) {
         return AVIF_RESULT_UNSUPPORTED_DEPTH;
@@ -527,7 +527,7 @@
     return result;
 }
 
-static avifBool avifImageIsOpaque(avifImage * image)
+static avifBool avifImageIsOpaque(const avifImage * image)
 {
     if (!image->alphaPlane) {
         return AVIF_TRUE;
@@ -555,7 +555,7 @@
     return AVIF_TRUE;
 }
 
-static void fillConfigBox(avifCodec * codec, avifImage * image, avifBool alpha)
+static void fillConfigBox(avifCodec * codec, const avifImage * image, avifBool alpha)
 {
     avifPixelFormatInfo formatInfo;
     avifGetPixelFormatInfo(image->yuvFormat, &formatInfo);