commit ef51c70607806bf8d5fc429ed68aefec346626c4
author Wan-Teh Chang <wtc@google.com> Wed Jul 10 21:56:31 2024 -0700
committer Wan-Teh Chang <wtc@google.com> Thu Jul 11 05:25:43 2024 -0700
tree 90a9adc37df8d62bda38ef182aae250e87338bae
parent c02cae89e542f4ee18f7de9f66ff867a493644cf

Fix default qualityAlpha calculation bug

When calculating qualityAlpha from minQuantizerAlpha and
maxQuantizerAlpha, use their values rather than whether or not they are
set (a boolean value).

apps/avifenc.c

diff --git a/apps/avifenc.c b/apps/avifenc.c
index e6432cf..6099fa4 100644
--- a/apps/avifenc.c
+++ b/apps/avifenc.c
@@ -2130,7 +2130,7 @@
                 if (fileSettings->minQuantizerAlpha.set) {
                     assert(fileSettings->maxQuantizerAlpha.set);
                     if (!fileSettings->qualityAlpha.set) {
-                        const int quantizerAlpha = (fileSettings->minQuantizerAlpha.set + fileSettings->maxQuantizerAlpha.set) / 2;
+                        const int quantizerAlpha = (fileSettings->minQuantizerAlpha.value + fileSettings->maxQuantizerAlpha.value) / 2;
                         const int qualityAlpha = ((63 - quantizerAlpha) * 100 + 31) / 63;
                         fileSettings->qualityAlpha = intSettingsEntryOf(qualityAlpha);
                     }