commit 17c580e642163f879735ce4e91f6345136d4a859
author Wan-Teh Chang <wtc@google.com> Sun Apr 02 20:46:14 2023 -0700
committer Wan-Teh Chang <wtc@google.com> Mon Apr 03 17:33:17 2023 +0000
tree dad930d528b5f8d9a76c46a4c71db2ac0e5a206e
parent 61fa302827b1673de5c3a63cb391682c7abb414b

Remove stage_idx variable in av1_fadst4_new_neon()

Fix the following Clang warning (Apple clang version 14.0.3 on macOS):
aom/av1/encoder/arm/neon/highbd_fwd_txfm_neon.c:2353:13: warning:
variable 'stage_idx' set but not used [-Wunused-but-set-variable]
    int32_t stage_idx = 0;
            ^

This variable was added in May 2020 in
https://aomedia-review.googlesource.com/c/aom/+/110261. I don't know why
the warning only shows up now.

Change-Id: If17c8b12e825aac657219700714a5f406b3c5b16

av1/encoder/arm/neon/highbd_fwd_txfm_neon.c

diff --git a/av1/encoder/arm/neon/highbd_fwd_txfm_neon.c b/av1/encoder/arm/neon/highbd_fwd_txfm_neon.c
index 147b1fb..0549a48 100644
--- a/av1/encoder/arm/neon/highbd_fwd_txfm_neon.c
+++ b/av1/encoder/arm/neon/highbd_fwd_txfm_neon.c
@@ -2350,37 +2350,30 @@
   cospi = cospi_arr(cos_bit);
   for (col = 0; col < col_num; col++) {
     // stage 0;
-    int32_t stage_idx = 0;
     int j;
     for (j = 0; j < 4; ++j) {
       buf0[j] = input[j * col_num + col];
     }
 
     // stage 1
-    stage_idx++;
     buf1[0] = buf0[3];
     buf1[1] = buf0[0];
     buf1[2] = buf0[1];
     buf1[3] = buf0[2];
 
     // stage 2
-    stage_idx++;
-
     btf_32_neon_type0(cospi[8], cospi[56], buf1[0], buf1[1], buf0[0], buf0[1],
                       v_cos_bit);
     btf_32_neon_type0(cospi[40], cospi[24], buf1[2], buf1[3], buf0[2], buf0[3],
                       v_cos_bit);
 
     // stage 3
-    stage_idx++;
     buf1[0] = vaddq_s32(buf0[0], buf0[2]);
     buf1[2] = vsubq_s32(buf0[0], buf0[2]);
     buf1[1] = vaddq_s32(buf0[1], buf0[3]);
     buf1[3] = vsubq_s32(buf0[1], buf0[3]);
 
     // stage 4
-    stage_idx++;
-
     cospi = cospi_arr(cos_bit);
     buf0[0] = buf1[0];
     buf0[1] = buf1[1];
@@ -2389,7 +2382,6 @@
                       v_cos_bit);
 
     // stage 5
-    stage_idx++;
     buf1[0] = buf0[0];
     buf1[1] = vnegq_s32(buf0[2]);
     buf1[2] = buf0[3];