commit 17fbdd5aec1625d42b0105fab52f36b01e7b535d
author Johann <johann.koenig@duck.com> Tue Sep 25 12:52:13 2018 -0700
committer Johann Koenig <johannkoenig@google.com> Mon Oct 15 14:15:36 2018 +0000
tree 3f94d128d343ac9b3df70e362c97fc6e71b58db6
parent f7e0b7f305b1dfdd352bf2c17561b916fcec6212

static analysis: ensure sym is set

Set sym to an invalid value so that the test fails if it is not decoded.

Change-Id: I5c953807c5a1e35aa0621cceddb16b0b7ba2567d

test/ec_test.cc

diff --git a/test/ec_test.cc b/test/ec_test.cc
index e6a5ea6..853abcb 100644
--- a/test/ec_test.cc
+++ b/test/ec_test.cc
@@ -22,7 +22,6 @@
   int sz;
   int i;
   int ret;
-  unsigned int sym;
   unsigned int seed;
   unsigned char *ptr;
   uint32_t ptr_sz;
@@ -90,6 +89,8 @@
         << " (Random seed: " << seed << ").\n";
     for (j = 0; j < sz; j++) {
       int dec_method;
+      unsigned int sym = data[j] + 1;  // Initialize sym to an invalid value.
+
       if (CDF_SHIFT == 0) {
         dec_method = 3 + (rand() & 1);
       } else {