commit 237404c2da7d9c82af47ddb43f2e2bec0d9d1819
author Mudassir Galaganath <mudassir.galaganath@ittiam.com> Wed Dec 21 13:02:19 2022 +0530
committer Wan-Teh Chang <wtc@google.com> Wed Dec 21 19:16:20 2022 +0000
tree db13005fbcb22b35afbd87ce87c425d8abf1235a
parent 05c81f88b0f6b88c12f7633ceb389389b30a097a

Add comment in should_prune_intra_modes_using_neighbors()

This CL adds a comment in the function
should_prune_intra_modes_using_neighbors() and also modifies
existing comments in av1_nonrd_pick_intra_mode().

Change-Id: I8626a8a7fbb46b42762db773d2de93f901d4161e

av1/encoder/nonrd_pickmode.c

diff --git a/av1/encoder/nonrd_pickmode.c b/av1/encoder/nonrd_pickmode.c
index 2ae1124..6e4c311 100644
--- a/av1/encoder/nonrd_pickmode.c
+++ b/av1/encoder/nonrd_pickmode.c
@@ -2575,6 +2575,8 @@
     PREDICTION_MODE left_mode) {
   if (!enable_intra_mode_pruning_using_neighbors) return false;
 
+  // Avoid pruning of DC_PRED as it is the most probable mode to win as per the
+  // statistics generated for nonrd intra mode evaluations.
   if (this_mode == DC_PRED) return false;
 
   // Enable the pruning for current mode only if it is not the winner mode of
@@ -2618,10 +2620,10 @@
 
     // As per the statistics generated for intra mode evaluation in the nonrd
     // path, it is found that the probability of H_PRED mode being the winner is
-    // very less when the best mode so far is V_PRED (out of DC_PRED and
-    // V_PRED). If V_PRED is the winner mode out of DC_PRED and V_PRED, it could
-    // imply the presence of a vertically dominant pattern. Hence, H_PRED mode
-    // is not evaluated.
+    // very low when the best mode so far is V_PRED (out of DC_PRED and V_PRED).
+    // If V_PRED is the winner mode out of DC_PRED and V_PRED, it could imply
+    // the presence of a vertically dominant pattern. Hence, H_PRED mode is not
+    // evaluated.
     if (cpi->sf.rt_sf.prune_h_pred_using_best_mode_so_far &&
         this_mode == H_PRED && best_mode == V_PRED)
       continue;
@@ -2634,8 +2636,8 @@
       if ((this_mode == V_PRED || this_mode == H_PRED) && source_variance <= 50)
         continue;
 
-      // As per the statistics, probability of SMOOTH_PRED being the winner
-      // is less when best mode so far is DC_PRED (out of DC_PRED, V_PRED and
+      // As per the statistics, probability of SMOOTH_PRED being the winner is
+      // low when best mode so far is DC_PRED (out of DC_PRED, V_PRED and
       // H_PRED). Hence, SMOOTH_PRED mode is not evaluated.
       if (best_mode == DC_PRED && this_mode == SMOOTH_PRED) continue;
     }