commit 2f6bfb2234a87752768f5ee5b4903d0ca17b8695
author Hui Su <huisu@google.com> Mon Apr 13 12:34:58 2020 -0700
committer Hui Su <huisu@google.com> Tue Apr 14 00:37:10 2020 +0000
tree bdd3db6b2e2582618c22da6f2d8d21bc88020d73
parent 72ffe5d5795dd28b8cb2c7a992d1d78efa11c6cb

Minor optimization and comment update

in av1_temporal_filter().

Change-Id: I579c76bb63b1c935b7d184dbd9e9e1ddd38afb5c

av1/encoder/temporal_filter.c

diff --git a/av1/encoder/temporal_filter.c b/av1/encoder/temporal_filter.c
index ea4cfb3..f827356 100644
--- a/av1/encoder/temporal_filter.c
+++ b/av1/encoder/temporal_filter.c
@@ -1210,12 +1210,17 @@
   const GF_GROUP *const gf_group = &cpi->gf_group;
   const uint8_t group_idx = gf_group->index;
   const FRAME_UPDATE_TYPE update_type = gf_group->update_type[group_idx];
-
   // Filter one more ARF if the lookahead index is leq 7 (w.r.t. 9-th frame).
   // This frame is ALWAYS a show existing frame.
   const int is_second_arf = (update_type == INTNL_ARF_UPDATE) &&
                             (filter_frame_lookahead_idx >= 7) &&
                             cpi->sf.hl_sf.second_alt_ref_filtering;
+  // TODO(anyone): Currently, we enforce the filtering strength on internal
+  // ARFs except the second ARF to be zero. We should investigate in which case
+  // it is more beneficial to use non-zero strength filtering.
+  if (update_type == INTNL_ARF_UPDATE && !is_second_arf) {
+    return 0;
+  }
 
   // TODO(yunqing): For INTNL_ARF_UPDATE type, the following me initialization
   // is used somewhere unexpectedly. Should be resolved later.
@@ -1227,13 +1232,6 @@
                     cpi->common.features.cur_frame_force_integer_mv,
                     cpi->common.features.allow_high_precision_mv, &cpi->td.mb);
 
-  // TODO(weitinglin): Currently, we enforce the filtering strength on internal
-  // ARFs to be zeros. We should investigate in which case it is more beneficial
-  // to use non-zero strength filtering.
-  if (update_type == INTNL_ARF_UPDATE && !is_second_arf) {
-    return 0;
-  }
-
   // Setup frame buffer for filtering.
   YV12_BUFFER_CONFIG *frames[MAX_LAG_BUFFERS] = { NULL };
   int num_frames_for_filtering = 0;