commit 3521376579aa657b55f5e47d6d48b6b58ad98d4e
author Yunqing Wang <yunqingwang@google.com> Wed Jul 24 16:20:20 2019 -0700
committer Yunqing Wang <yunqingwang@google.com> Fri Jul 26 16:18:16 2019 +0000
tree 141c217ac68f01400a7f44c035bf5a074112fa6b
parent 65567292f993204fd57f278e5e56b4e482c2fa50

Tune speed 5 speed features

Disabled some speed 5 speed features since they gave bad quality/
speed tradeoff.

This recovered ~4% quality. AWCY result:
sp5-07-23-2019@2019-07-23T22:55:56.539Z -> sp5-92301@2019-07-24T23:30:06.286Z

   PSNR | PSNR Cb | PSNR Cr | PSNR HVS |    SSIM | MS SSIM | CIEDE 2000
-3.9383 | -4.6329 | -4.0248 |  -3.8365 | -4.0868 | -4.0124 |    -4.7066

The average encoder time increase is 16.76%.

Change-Id: I1d53cb1188d1b214524427b635f35d367311e216

av1/encoder/speed_features.c

diff --git a/av1/encoder/speed_features.c b/av1/encoder/speed_features.c
index 58fa2ee..4ccab69b 100644
--- a/av1/encoder/speed_features.c
+++ b/av1/encoder/speed_features.c
@@ -359,20 +359,27 @@
     sf->intra_uv_mode_mask[TX_32X32] = UV_INTRA_DC_H_V_CFL;
     sf->intra_y_mode_mask[TX_16X16] = INTRA_DC_H_V;
     sf->intra_uv_mode_mask[TX_16X16] = UV_INTRA_DC_H_V_CFL;
-    sf->tx_size_search_method = USE_LARGESTALL;
-    sf->mv.search_method = BIGDIA;
+
     sf->mv.subpel_search_method = SUBPEL_TREE_PRUNED_MORE;
-    sf->adaptive_rd_thresh = 4;
-    sf->mode_search_skip_flags =
-        (cm->current_frame.frame_type == KEY_FRAME)
-            ? 0
-            : FLAG_SKIP_INTRA_DIRMISMATCH | FLAG_SKIP_INTRA_BESTINTER |
-                  FLAG_SKIP_COMP_BESTINTRA | FLAG_SKIP_INTRA_LOWVAR |
-                  FLAG_EARLY_TERMINATE;
-    sf->disable_filter_search_var_thresh = 200;
-    sf->use_fast_coef_costing = 1;
-    sf->partition_search_breakout_rate_thr = 300;
-    sf->use_transform_domain_distortion = 2;
+
+    // TODO(any): The following features have no impact on quality and speed,
+    // and are disabled.
+    // sf->disable_filter_search_var_thresh = 200;
+    // sf->use_fast_coef_costing = 1;
+    // sf->partition_search_breakout_rate_thr = 300;
+
+    // TODO(any): The following features give really bad quality/speed trade
+    // off. Needs to be re-worked.
+    // sf->tx_size_search_method = USE_LARGESTALL;
+    // sf->mv.search_method = BIGDIA;
+    // sf->adaptive_rd_thresh = 4;
+    // sf->mode_search_skip_flags =
+    //     (cm->current_frame.frame_type == KEY_FRAME)
+    //     ? 0
+    //     : FLAG_SKIP_INTRA_DIRMISMATCH | FLAG_SKIP_INTRA_BESTINTER |
+    //     FLAG_SKIP_COMP_BESTINTRA | FLAG_SKIP_INTRA_LOWVAR |
+    //     FLAG_EARLY_TERMINATE;
+    // sf->use_transform_domain_distortion = 2;
   }
 
   if (speed >= 6) {