Consolidate real-time speed presets
Current real-time speed 0 to 3 features are mostly copied from
good-quality mode, which are very slow. Consolidate these speeds,
so we don't need to maintain/test them. This also avoid those
speeds are used mistakenly. This CL doesn't change quality & speed
performance for speed >=4.
Change-Id: I7ee9421254050ad26e101f27c1481825c35600aa
diff --git a/av1/encoder/speed_features.c b/av1/encoder/speed_features.c
index c69f89b..3570571 100644
--- a/av1/encoder/speed_features.c
+++ b/av1/encoder/speed_features.c
@@ -1219,34 +1219,60 @@
AV1_COMMON *const cm = &cpi->common;
const int boosted = frame_is_boosted(cpi);
- // Speed 0 for all speed features that give neutral coding performance change.
- sf->gm_sf.gm_search_type = GM_REDUCED_REF_SEARCH_SKIP_L2_L3;
+ // TODO(any, yunqing): tune these features for real-time use cases.
+ sf->gm_sf.gm_search_type = GM_REDUCED_REF_SEARCH_SKIP_L2_L3_ARF2;
- sf->part_sf.less_rectangular_check_level = 1;
- sf->part_sf.ml_prune_partition = 1;
- sf->part_sf.prune_ext_partition_types_search_level = 1;
- sf->part_sf.reuse_prev_rd_results_for_part_ab = 1;
- sf->part_sf.use_best_rd_for_pruning = 1;
+ sf->hl_sf.superres_auto_search_type = SUPERRES_AUTO_SOLO;
+ sf->hl_sf.recode_loop = ALLOW_RECODE_KFARFGF;
- // TODO(debargha): Test, tweak and turn on either 1 or 2
sf->inter_sf.inter_mode_rd_model_estimation = 0;
- sf->inter_sf.disable_interintra_wedge_var_thresh = 0;
- sf->inter_sf.disable_interinter_wedge_var_thresh = 0;
sf->inter_sf.model_based_post_interp_filter_breakout = 1;
sf->inter_sf.prune_compound_using_single_ref = 0;
sf->inter_sf.prune_mode_search_simple_translation = 1;
sf->inter_sf.prune_ref_frame_for_rect_partitions = !boosted;
sf->inter_sf.reduce_inter_modes = 1;
- sf->inter_sf.selective_ref_frame = 1;
- sf->inter_sf.use_dist_wtd_comp_flag = DIST_WTD_COMP_SKIP_MV_SEARCH;
+ sf->inter_sf.reuse_inter_intra_mode = 1;
+ sf->inter_sf.comp_inter_joint_search_thresh = BLOCK_SIZES_ALL;
+ sf->inter_sf.disable_interinter_wedge_var_thresh = 100;
+ sf->inter_sf.fast_wedge_sign_estimate = 1;
+ sf->inter_sf.prune_comp_type_by_comp_avg = 2;
+ sf->inter_sf.use_dist_wtd_comp_flag = DIST_WTD_COMP_DISABLED;
+ sf->inter_sf.adaptive_rd_thresh = 2;
+ sf->inter_sf.mv_cost_upd_level = INTERNAL_COST_UPD_SBROW;
+ sf->inter_sf.disable_interintra_wedge_var_thresh = UINT_MAX;
+ sf->inter_sf.prune_comp_search_by_single_result = 2;
+ sf->inter_sf.selective_ref_frame = 4;
sf->interp_sf.use_fast_interpolation_filter_search = 1;
+ sf->interp_sf.use_interp_filter = 1;
+ sf->interp_sf.adaptive_interp_filter_search = 1;
+ sf->interp_sf.cb_pred_filter_search = 0;
+ sf->interp_sf.disable_dual_filter = 1;
sf->intra_sf.dv_cost_upd_level = INTERNAL_COST_UPD_OFF;
sf->intra_sf.intra_pruning_with_hog = 1;
+ sf->lpf_sf.dual_sgr_penalty_level = 1;
+ sf->lpf_sf.cdef_pick_method = CDEF_FAST_SEARCH_LVL1;
+
sf->mv_sf.full_pixel_search_level = 1;
sf->mv_sf.exhaustive_searches_thresh = INT_MAX;
+ sf->mv_sf.obmc_full_pixel_search_level = 1;
+ sf->mv_sf.auto_mv_step_size = 1;
+ sf->mv_sf.subpel_iters_per_step = 1;
+ sf->mv_sf.use_accurate_subpel_search = USE_2_TAPS;
+
+ sf->part_sf.ml_prune_partition = 1;
+ sf->part_sf.reuse_prev_rd_results_for_part_ab = 1;
+ sf->part_sf.use_best_rd_for_pruning = 1;
+ sf->part_sf.prune_ext_partition_types_search_level = 2;
+ sf->part_sf.simple_motion_search_prune_rect = 1;
+ sf->part_sf.allow_partition_search_skip = 1;
+ sf->part_sf.partition_search_breakout_rate_thr = 80;
+ sf->part_sf.less_rectangular_check_level = 2;
+
+ sf->rd_sf.tx_domain_dist_thres_level = 1;
+ sf->rd_sf.tx_domain_dist_level = 1;
sf->rt_sf.check_intra_pred_nonrd = 1;
sf->rt_sf.estimate_motion_for_var_based_partition = 1;
@@ -1259,102 +1285,26 @@
sf->rt_sf.use_real_time_ref_set = 0;
sf->rt_sf.check_scene_detection = 0;
sf->rt_sf.overshoot_detection_cbr = NO_DETECTION;
- sf->tx_sf.adaptive_txb_search_level = 1;
- sf->tx_sf.intra_tx_size_search_init_depth_sqr = 1;
- sf->tx_sf.model_based_prune_tx_search_level = 1;
- sf->tx_sf.tx_type_search.use_reduced_intra_txset = 1;
sf->rt_sf.fullpel_search_step_param = 0;
sf->rt_sf.skip_loopfilter_non_reference = 0;
- sf->hl_sf.superres_auto_search_type = SUPERRES_AUTO_SOLO;
+ sf->tx_sf.intra_tx_size_search_init_depth_sqr = 1;
+ sf->tx_sf.tx_type_search.use_reduced_intra_txset = 1;
+ sf->tx_sf.adaptive_txb_search_level = 2;
+ sf->tx_sf.intra_tx_size_search_init_depth_rect = 1;
+ sf->tx_sf.tx_size_search_lgr_block = 1;
+ sf->tx_sf.tx_type_search.ml_tx_split_thresh = 4000;
+ sf->tx_sf.tx_type_search.skip_tx_search = 1;
+ sf->tx_sf.use_intra_txb_hash = 1;
+ sf->tx_sf.inter_tx_size_search_init_depth_rect = 1;
+ sf->tx_sf.inter_tx_size_search_init_depth_sqr = 1;
+ sf->tx_sf.model_based_prune_tx_search_level = 0;
+ sf->tx_sf.tx_type_search.prune_2d_txfm_mode = TX_TYPE_PRUNE_2;
- if (speed >= 1) {
- sf->gm_sf.gm_search_type = GM_REDUCED_REF_SEARCH_SKIP_L2_L3_ARF2;
+ sf->winner_mode_sf.tx_size_search_level = boosted ? 0 : 2;
- sf->part_sf.prune_ext_partition_types_search_level = 2;
- sf->part_sf.simple_motion_search_prune_rect = 1;
-
- sf->mv_sf.obmc_full_pixel_search_level = 1;
- sf->mv_sf.use_accurate_subpel_search = USE_4_TAPS;
-
- sf->inter_sf.prune_comp_search_by_single_result = 1;
- sf->inter_sf.reuse_inter_intra_mode = 1;
- sf->inter_sf.selective_ref_frame = 2;
- sf->inter_sf.disable_interintra_wedge_var_thresh = 0;
- sf->inter_sf.disable_interinter_wedge_var_thresh = 0;
- sf->inter_sf.prune_comp_type_by_comp_avg = 1;
-
- sf->interp_sf.cb_pred_filter_search = 1;
- sf->interp_sf.use_interp_filter = 1;
-
- sf->tx_sf.adaptive_txb_search_level = 2;
- sf->tx_sf.intra_tx_size_search_init_depth_rect = 1;
- sf->tx_sf.tx_size_search_lgr_block = 1;
- sf->tx_sf.tx_type_search.ml_tx_split_thresh = 4000;
- sf->tx_sf.tx_type_search.skip_tx_search = 1;
- sf->tx_sf.use_intra_txb_hash = 1;
-
- sf->rd_sf.tx_domain_dist_level = boosted ? 0 : 1;
- sf->rd_sf.tx_domain_dist_thres_level = 1;
-
- sf->lpf_sf.dual_sgr_penalty_level = 1;
- }
-
- if (speed >= 2) {
- sf->part_sf.allow_partition_search_skip = 1;
- sf->part_sf.partition_search_breakout_rate_thr = 80;
-
- sf->mv_sf.auto_mv_step_size = 1;
- sf->mv_sf.subpel_iters_per_step = 1;
-
- sf->inter_sf.adaptive_rd_thresh = 1;
- sf->inter_sf.comp_inter_joint_search_thresh = BLOCK_SIZES_ALL;
- sf->inter_sf.disable_interintra_wedge_var_thresh = 100;
- sf->inter_sf.disable_interinter_wedge_var_thresh = 100;
- sf->inter_sf.fast_wedge_sign_estimate = 1;
- sf->inter_sf.prune_comp_type_by_comp_avg = 2;
- sf->inter_sf.selective_ref_frame = 3;
- sf->inter_sf.use_dist_wtd_comp_flag = DIST_WTD_COMP_DISABLED;
-
- sf->interp_sf.adaptive_interp_filter_search = 1;
- sf->interp_sf.cb_pred_filter_search = 0;
- sf->interp_sf.disable_dual_filter = 1;
-
- sf->tx_sf.inter_tx_size_search_init_depth_rect = 1;
- sf->tx_sf.inter_tx_size_search_init_depth_sqr = 1;
- sf->tx_sf.model_based_prune_tx_search_level = 0;
-
- sf->lpf_sf.cdef_pick_method = CDEF_FAST_SEARCH_LVL1;
- }
-
- if (speed >= 3) {
- sf->hl_sf.recode_loop = ALLOW_RECODE_KFARFGF;
-
- sf->gm_sf.gm_search_type = GM_REDUCED_REF_SEARCH_SKIP_L2_L3_ARF2;
-
- sf->part_sf.less_rectangular_check_level = 2;
-
- sf->mv_sf.use_accurate_subpel_search = USE_2_TAPS;
- // adaptive_motion_search breaks encoder multi-thread tests.
- // The values in x->pred_mv[] differ for single and multi-thread cases.
- // See aomedia:1778.
- // sf->mv_sf.adaptive_motion_search = 1;
-
- sf->inter_sf.adaptive_rd_thresh = 2;
- sf->inter_sf.mv_cost_upd_level = INTERNAL_COST_UPD_SBROW;
- // TODO(yunqing): evaluate this speed feature for speed 1 & 2, and combine
- // it with cpi->sf.disable_wedge_search_var_thresh.
- sf->inter_sf.disable_interintra_wedge_var_thresh = UINT_MAX;
- sf->inter_sf.prune_comp_search_by_single_result = 2;
- sf->inter_sf.selective_ref_frame = 4;
-
- sf->tx_sf.tx_type_search.prune_2d_txfm_mode = TX_TYPE_PRUNE_2;
-
- sf->rd_sf.tx_domain_dist_level = 1;
-
- sf->winner_mode_sf.tx_size_search_level = boosted ? 0 : 2;
- }
-
+ // TODO(Yunqing, any): speed 4 overall speed/quality tradeoff isn't good. Need
+ // evaluate it.
if (speed >= 4) {
sf->mv_sf.subpel_search_method = SUBPEL_TREE_PRUNED;
@@ -1435,6 +1385,8 @@
sf->rt_sf.use_temporal_noise_estimate = 1;
}
+ // TODO(Yunqing, any): speed 6 overall speed/quality tradeoff is bad. Need
+ // evaluate it.
if (speed >= 6) {
sf->part_sf.adjust_var_based_rd_partitioning = 1;
sf->lpf_sf.cdef_pick_method = CDEF_PICK_FROM_Q;
