Resolve TODO: Inactive_zone_cols Place holder but for now no plans to implement. The inactive zones (rows and columns) act to optimize behavior in two pass encoding content where there is a dead zone added to pad the real image to a different aspect ratio. This is comment in the case of vertical padding or "letterboxing" but less so for padding portrait format content horizontally, which tends to only apply to slide shows of portrait stills. The code here is a place holder mirroring the behavior for rows, but there are no plans to implement this at present. Change-Id: Idc9f3ba3b7e6a3927555fe2e14a62b0d54eb1227
diff --git a/av1/encoder/firstpass.c b/av1/encoder/firstpass.c index 24ed329..5271dc5 100644 --- a/av1/encoder/firstpass.c +++ b/av1/encoder/firstpass.c
@@ -884,7 +884,7 @@ fps.pcnt_neutral = (double)stats->neutral_count / num_mbs; fps.intra_skip_pct = (double)stats->intra_skip_count / num_mbs; fps.inactive_zone_rows = (double)stats->image_data_start_row; - fps.inactive_zone_cols = (double)0; // TODO(paulwilkins): fix + fps.inactive_zone_cols = (double)0; // Placeholder: not currently supported. fps.raw_error_stdev = raw_err_stdev; fps.is_flash = 0; fps.noise_var = (double)0;