googletest: enable failure on uninstantiated tests
this currently is a warning, but the tree should be clean now in the
default x86-64 configuration so we can use it to prevent regressions and
find any remaining issues in other configurations.
BUG=aomedia:2653
BUG=b/159031844
Change-Id: I9a7b798b2efea8a99546d856a313568cb0d4ddf9
diff --git a/third_party/googletest/README.libaom b/third_party/googletest/README.libaom
index 9b8a863..ea30672 100644
--- a/third_party/googletest/README.libaom
+++ b/third_party/googletest/README.libaom
@@ -12,6 +12,5 @@
generation.
Local Modifications:
-- Replace everything in:
- third_party/googletest/src/googletest/src/
- third_party/googletest/src/googletest/include/
+- Enable kErrorOnUninstantiatedParameterizedTest and
+ kErrorOnUninstantiatedTypeParameterizedTest in gtest.cc
diff --git a/third_party/googletest/src/googletest/src/gtest.cc b/third_party/googletest/src/googletest/src/gtest.cc
index 5b4037f..021c82e 100644
--- a/third_party/googletest/src/googletest/src/gtest.cc
+++ b/third_party/googletest/src/googletest/src/gtest.cc
@@ -400,8 +400,8 @@
// inserted to report ether an error or a log message.
//
// This configuration bit will likely be removed at some point.
-constexpr bool kErrorOnUninstantiatedParameterizedTest = false;
-constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = false;
+constexpr bool kErrorOnUninstantiatedParameterizedTest = true;
+constexpr bool kErrorOnUninstantiatedTypeParameterizedTest = true;
// A test that fails at a given file/line location with a given message.
class FailureTest : public Test {
