commit 7395a3832cea2e2a62683e7450dd6dbff1449330
author Jingning Han <jingning@google.com> Mon Jan 30 11:01:18 2023 -0800
committer Jingning Han <jingning@google.com> Mon Jan 30 20:13:33 2023 +0000
tree f99ae4b90a335c3a71c924e76be52795122cc931
parent ad16a2293ccb1058d832d93ba3e964151f7f0a89

Remove an assertion condition in convolve_c function

The temporary sum can be less than 0 when 12-tap filter is used.
This condition has been covered by the SIMD functions. Remove the
assertion condition in the C function.

BUG=b/262933491

Change-Id: I36662cbd45ac755815a5b4eaffb94df5c08dc475

av1/common/convolve.c

diff --git a/av1/common/convolve.c b/av1/common/convolve.c
index 54b2bb0..fad9869 100644
--- a/av1/common/convolve.c
+++ b/av1/common/convolve.c
@@ -640,7 +640,7 @@
       for (int k = 0; k < filter_params_x->taps; ++k) {
         sum += x_filter[k] * src_horiz[y * src_stride + x - fo_horiz + k];
       }
-      assert(0 <= sum && sum < (1 << (bd + FILTER_BITS + 1)));
+      assert(sum < (1 << (bd + FILTER_BITS + 1)));
       im_block[y * im_stride + x] =
           ROUND_POWER_OF_TWO(sum, conv_params->round_0);
     }