commit 818489af4378bd58c455e2bccba3d85df0b95a99
author Wan-Teh Chang <wtc@google.com> Fri Sep 16 13:25:50 2022 -0700
committer Wan-Teh Chang <wtc@google.com> Fri Sep 16 21:45:18 2022 +0000
tree 641f0ceff7c10e489821152848df7ad5b6086f6f
parent a95eff442016f6a6ff45defa1381e57b2fe38630

Add an assertion to av1_set_ssim_rdmult()

Assert that cpi->ssim_rdmult_scaling_factors[index] is nonzero in
av1_set_ssim_rdmult(). cpi->ssim_rdmult_scaling_factors[index] is passed
to log(), so it cannot be zero.

The assertion helps detect if the cpi->ssim_rdmult_scaling_factors[]
array (zero-initialized at allocation time) is not set up correctly
before use.

Bug: aomedia:3336
Change-Id: I5d37560a2b8e2a6f6549550a3f1917ce4852a876

av1/encoder/encodeframe_utils.c

diff --git a/av1/encoder/encodeframe_utils.c b/av1/encoder/encodeframe_utils.c
index df248ca..2bc61c7 100644
--- a/av1/encoder/encodeframe_utils.c
+++ b/av1/encoder/encodeframe_utils.c
@@ -40,6 +40,7 @@
     for (col = mi_col / num_mi_h;
          col < num_cols && col < mi_col / num_mi_h + num_bcols; ++col) {
       const int index = row * num_cols + col;
+      assert(cpi->ssim_rdmult_scaling_factors[index] != 0.0);
       geom_mean_of_scale += log(cpi->ssim_rdmult_scaling_factors[index]);
       num_of_mi += 1.0;
     }