commit 8a40f783702f9946ee767f55bbefe369e483769e
author James Zern <jzern@google.com> Mon Mar 27 12:32:41 2023 -0700
committer James Zern <jzern@google.com> Wed Mar 29 18:30:10 2023 +0000
tree 3c10d4f3458e231bd287b944619b683cfc39e3fd
parent 413b149e4b434a0030c473793750c6f31b44c1c8

cpu_used_firstpass_test: fix -Wfloat-conversion warning

use the std::abs(double) overload to avoid:

test/cpu_used_firstpass_test.cc: In member function ‘void
{anonymous}::CpuUsedFirstpassTest::DoTest()’:
test/cpu_used_firstpass_test.cc:87:30: warning: conversion from ‘double’
to ‘int’ may change value [-Wfloat-conversion]
   87 |     psnr_diff = abs(ref_psnr - GetAveragePsnr());
      |                     ~~~~~~~~~^~~~~~~~~~~~~~~~~~

Change-Id: I0fd9a44041ea022bac5af3b0e47b34c2fc3cf0d9

test/cpu_used_firstpass_test.cc

diff --git a/test/cpu_used_firstpass_test.cc b/test/cpu_used_firstpass_test.cc
index c53db6e..cfffcd7a 100644
--- a/test/cpu_used_firstpass_test.cc
+++ b/test/cpu_used_firstpass_test.cc
@@ -9,6 +9,8 @@
  * PATENTS file, you can obtain it at www.aomedia.org/license/patent.
  */
 
+#include <cstdlib>
+
 #include "test/codec_factory.h"
 #include "test/encode_test_driver.h"
 #include "test/i420_video_source.h"
@@ -84,7 +86,7 @@
     first_pass_cpu_used_ = GET_PARAM(1);
     if (first_pass_cpu_used_ == second_pass_cpu_used_) return;
     ASSERT_NO_FATAL_FAILURE(RunLoop(&video));
-    psnr_diff = abs(ref_psnr - GetAveragePsnr());
+    psnr_diff = std::abs(ref_psnr - GetAveragePsnr());
     EXPECT_LT(psnr_diff, GetPsnrDiffThreshold())
         << "first pass cpu used = " << first_pass_cpu_used_
         << ", second pass cpu used = " << second_pass_cpu_used_;