Add a unit test for assert failure at mcomp.c:1760 Convert libavif's ProgressiveTest.DimensionChange test to a libaom test. Run ./test_libaom \ --gtest_filter=AVIFProgressiveTest.DISABLED_DimensionChange \ --gtest_also_run_disabled_tests test_libaom: aom/av1/encoder/mcomp.c:1760: av1_full_pixel_search: Assertion `ms_params->ms_buffers.ref->stride == ms_params->search_sites->stride' failed. Aborted Also convert libavif's ProgressiveTest.QualityChange test to a libaom test. Bug: aomedia:3348 Change-Id: I074fabd590cf3d9738df41ad69b1d84c31287bbe
diff --git a/test/avif_progressive_test.cc b/test/avif_progressive_test.cc new file mode 100644 index 0000000..e32ab6e --- /dev/null +++ b/test/avif_progressive_test.cc
@@ -0,0 +1,194 @@ +/* + * Copyright (c) 2023, Alliance for Open Media. All rights reserved + * + * This source code is subject to the terms of the BSD 2 Clause License and + * the Alliance for Open Media Patent License 1.0. If the BSD 2 Clause License + * was not distributed with this source code in the LICENSE file, you can + * obtain it at www.aomedia.org/license/software. If the Alliance for Open + * Media Patent License 1.0 was not distributed with this source code in the + * PATENTS file, you can obtain it at www.aomedia.org/license/patent. + */ + +#include <vector> + +#include "aom/aomcx.h" +#include "aom/aom_codec.h" +#include "aom/aom_encoder.h" +#include "aom/aom_image.h" +#include "config/aom_config.h" +#include "third_party/googletest/src/googletest/include/gtest/gtest.h" + +namespace { + +// This test emulates how libavif calls libaom functions to encode a +// progressive AVIF image in libavif's ProgressiveTest.QualityChange test. +TEST(AVIFProgressiveTest, QualityChange) { + constexpr int kWidth = 256; + constexpr int kHeight = 256; + // Dummy buffer of neutral gray samples. + constexpr size_t kBufferSize = 3 * kWidth * kHeight; + std::vector<unsigned char> buffer(kBufferSize, + static_cast<unsigned char>(128)); + + aom_image_t img; + EXPECT_EQ(&img, aom_img_wrap(&img, AOM_IMG_FMT_I444, kWidth, kHeight, 1, + buffer.data())); + + aom_codec_iface_t *iface = aom_codec_av1_cx(); + aom_codec_enc_cfg_t cfg; + const unsigned int usage = AOM_USAGE_GOOD_QUALITY; + EXPECT_EQ(AOM_CODEC_OK, aom_codec_enc_config_default(iface, &cfg, usage)); + cfg.g_w = kWidth; + cfg.g_h = kHeight; + cfg.rc_end_usage = AOM_Q; + cfg.g_profile = 1; + cfg.g_bit_depth = AOM_BITS_8; + cfg.g_input_bit_depth = 8; + cfg.g_lag_in_frames = 0; + cfg.rc_min_quantizer = 50; + cfg.rc_max_quantizer = 50; + aom_codec_ctx_t enc; + EXPECT_EQ(AOM_CODEC_OK, aom_codec_enc_init(&enc, iface, &cfg, 0)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_control(&enc, AOME_SET_CQ_LEVEL, 50)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_NUMBER_SPATIAL_LAYERS, 2)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_control(&enc, AOME_SET_CPUUSED, 6)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_TUNING, AOM_TUNE_SSIM)); + + // First frame (layer 0) + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_SPATIAL_LAYER_ID, 0)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AV1E_SET_COLOR_RANGE, AOM_CR_FULL_RANGE)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_encode(&enc, &img, 0, 1, 0)); + const aom_codec_cx_pkt_t *pkt; + aom_codec_iter_t iter; + iter = nullptr; + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_NE(pkt, nullptr); + EXPECT_EQ(pkt->kind, AOM_CODEC_CX_FRAME_PKT); + // pkt->data.frame.flags is 0x1f0011. + EXPECT_EQ(pkt->data.frame.flags & AOM_FRAME_IS_KEY, AOM_FRAME_IS_KEY); + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_EQ(pkt, nullptr); + + // Second frame (layer 1) + cfg.rc_min_quantizer = 0; + cfg.rc_max_quantizer = 0; + EXPECT_EQ(AOM_CODEC_OK, aom_codec_enc_config_set(&enc, &cfg)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_control(&enc, AOME_SET_CQ_LEVEL, 0)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_control(&enc, AV1E_SET_LOSSLESS, 1)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_SPATIAL_LAYER_ID, 1)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AV1E_SET_COLOR_RANGE, AOM_CR_FULL_RANGE)); + aom_enc_frame_flags_t encode_flags = + AOM_EFLAG_NO_REF_GF | AOM_EFLAG_NO_REF_ARF | AOM_EFLAG_NO_REF_BWD | + AOM_EFLAG_NO_REF_ARF2 | AOM_EFLAG_NO_UPD_GF | AOM_EFLAG_NO_UPD_ARF; + EXPECT_EQ(AOM_CODEC_OK, aom_codec_encode(&enc, &img, 0, 1, encode_flags)); + iter = nullptr; + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_NE(pkt, nullptr); + EXPECT_EQ(pkt->kind, AOM_CODEC_CX_FRAME_PKT); + // pkt->data.frame.flags is 0. + EXPECT_EQ(pkt->data.frame.flags & AOM_FRAME_IS_KEY, 0u); + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_EQ(pkt, nullptr); + + // Flush encoder + EXPECT_EQ(AOM_CODEC_OK, aom_codec_encode(&enc, nullptr, 0, 1, 0)); + iter = nullptr; + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_EQ(pkt, nullptr); + + EXPECT_EQ(AOM_CODEC_OK, aom_codec_destroy(&enc)); +} + +// This test emulates how libavif calls libaom functions to encode a +// progressive AVIF image in libavif's ProgressiveTest.DimensionChange test. +// TODO(https://crbug.com/aomedia/3348): Fix the assertion failure at +// av1/encoder/mcomp.c:1760 and enable this test. +TEST(AVIFProgressiveTest, DISABLED_DimensionChange) { + constexpr int kWidth = 256; + constexpr int kHeight = 256; + // Dummy buffer of neutral gray samples. + constexpr size_t kBufferSize = 3 * kWidth * kHeight; + std::vector<unsigned char> buffer(kBufferSize, + static_cast<unsigned char>(128)); + + aom_image_t img; + EXPECT_EQ(&img, aom_img_wrap(&img, AOM_IMG_FMT_I444, kWidth, kHeight, 1, + buffer.data())); + + aom_codec_iface_t *iface = aom_codec_av1_cx(); + aom_codec_enc_cfg_t cfg; + const unsigned int usage = AOM_USAGE_GOOD_QUALITY; + EXPECT_EQ(AOM_CODEC_OK, aom_codec_enc_config_default(iface, &cfg, usage)); + cfg.g_w = kWidth; + cfg.g_h = kHeight; + cfg.rc_end_usage = AOM_Q; + cfg.g_profile = 1; + cfg.g_bit_depth = AOM_BITS_8; + cfg.g_input_bit_depth = 8; + cfg.g_lag_in_frames = 0; + cfg.rc_min_quantizer = 0; + cfg.rc_max_quantizer = 0; + aom_codec_ctx_t enc; + EXPECT_EQ(AOM_CODEC_OK, aom_codec_enc_init(&enc, iface, &cfg, 0)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_control(&enc, AOME_SET_CQ_LEVEL, 0)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_control(&enc, AV1E_SET_LOSSLESS, 1)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_NUMBER_SPATIAL_LAYERS, 2)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_control(&enc, AOME_SET_CPUUSED, 6)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_TUNING, AOM_TUNE_SSIM)); + + // First frame (layer 0) + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_SPATIAL_LAYER_ID, 0)); + aom_scaling_mode_t scaling_mode = { AOME_ONETWO, AOME_ONETWO }; + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_SCALEMODE, &scaling_mode)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AV1E_SET_COLOR_RANGE, AOM_CR_FULL_RANGE)); + EXPECT_EQ(AOM_CODEC_OK, aom_codec_encode(&enc, &img, 0, 1, 0)); + const aom_codec_cx_pkt_t *pkt; + aom_codec_iter_t iter; + iter = nullptr; + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_NE(pkt, nullptr); + EXPECT_EQ(pkt->kind, AOM_CODEC_CX_FRAME_PKT); + // pkt->data.frame.flags is 0x1f0011. + EXPECT_EQ(pkt->data.frame.flags & AOM_FRAME_IS_KEY, AOM_FRAME_IS_KEY); + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_EQ(pkt, nullptr); + + // Second frame (layer 1) + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AOME_SET_SPATIAL_LAYER_ID, 1)); + EXPECT_EQ(AOM_CODEC_OK, + aom_codec_control(&enc, AV1E_SET_COLOR_RANGE, AOM_CR_FULL_RANGE)); + aom_enc_frame_flags_t encode_flags = + AOM_EFLAG_NO_REF_GF | AOM_EFLAG_NO_REF_ARF | AOM_EFLAG_NO_REF_BWD | + AOM_EFLAG_NO_REF_ARF2 | AOM_EFLAG_NO_UPD_GF | AOM_EFLAG_NO_UPD_ARF; + EXPECT_EQ(AOM_CODEC_OK, aom_codec_encode(&enc, &img, 0, 1, encode_flags)); + iter = nullptr; + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_NE(pkt, nullptr); + EXPECT_EQ(pkt->kind, AOM_CODEC_CX_FRAME_PKT); + // pkt->data.frame.flags is 0. + EXPECT_EQ(pkt->data.frame.flags & AOM_FRAME_IS_KEY, 0u); + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_EQ(pkt, nullptr); + + // Flush encoder + EXPECT_EQ(AOM_CODEC_OK, aom_codec_encode(&enc, nullptr, 0, 1, 0)); + iter = nullptr; + pkt = aom_codec_get_cx_data(&enc, &iter); + EXPECT_EQ(pkt, nullptr); + + EXPECT_EQ(AOM_CODEC_OK, aom_codec_destroy(&enc)); +} + +} // namespace
diff --git a/test/test.cmake b/test/test.cmake index 398f1e5..ebf4404 100644 --- a/test/test.cmake +++ b/test/test.cmake
@@ -53,6 +53,7 @@ "${AOM_ROOT}/test/active_map_test.cc" "${AOM_ROOT}/test/aq_segment_test.cc" "${AOM_ROOT}/test/av1_external_partition_test.cc" + "${AOM_ROOT}/test/avif_progressive_test.cc" "${AOM_ROOT}/test/borders_test.cc" "${AOM_ROOT}/test/cpu_speed_test.cc" "${AOM_ROOT}/test/cpu_used_firstpass_test.cc" @@ -107,6 +108,7 @@ list(REMOVE_ITEM AOM_UNIT_TEST_ENCODER_SOURCES "${AOM_ROOT}/test/allintra_end_to_end_test.cc" "${AOM_ROOT}/test/av1_external_partition_test.cc" + "${AOM_ROOT}/test/avif_progressive_test.cc" "${AOM_ROOT}/test/borders_test.cc" "${AOM_ROOT}/test/cpu_speed_test.cc" "${AOM_ROOT}/test/cpu_used_firstpass_test.cc"