commit a017ff897e0cc8517bf66599400584a9bedd61d8
author Yaowu Xu <yaowu@google.com> Wed Nov 20 15:32:21 2019 -0800
committer Yaowu Xu <yaowu@google.com> Thu Nov 21 01:25:59 2019 +0000
tree dffdfa081f98f3772eafd182fcfa0324fd094d1c
parent b646a945f54e1bb1f97f4d46028a356c449e996c

Add a clamp to avoid float overflow

BUG=aomedia:2541

Change-Id: I560a39fd553f4b3814fc5b99217694d560cc257e

aom_dsp/noise_model.c

diff --git a/aom_dsp/noise_model.c b/aom_dsp/noise_model.c
index 528efd9..c7a0003 100644
--- a/aom_dsp/noise_model.c
+++ b/aom_dsp/noise_model.c
@@ -636,10 +636,12 @@
         //    [{var}, {ratio}, {trace}, {norm}, offset]
         // with one of the most discriminative being simply the variance.
         const double weights[5] = { -6682, -0.2056, 13087, -12434, 2.5694 };
-        const float score =
-            (float)(1.0 / (1 + exp(-(weights[0] * var + weights[1] * ratio +
-                                     weights[2] * trace + weights[3] * norm +
-                                     weights[4]))));
+        double sum_weights = weights[0] * var + weights[1] * ratio +
+                             weights[2] * trace + weights[3] * norm +
+                             weights[4];
+        // clamp the value to [-25.0, 100.0] to prevent overflow
+        sum_weights = fclamp(sum_weights, -25.0, 100.0);
+        const float score = (float)(1.0 / (1 + exp(-sum_weights)));
         flat_blocks[by * num_blocks_w + bx] = is_flat ? 255 : 0;
         scores[by * num_blocks_w + bx].score = var > kVarThreshold ? score : 0;
         scores[by * num_blocks_w + bx].index = by * num_blocks_w + bx;