commit cfaec3d1991e0914842a451991542d220f813867
author Aniket Wanare <Aniket.wanare@ittiam.com> Wed Nov 18 10:58:32 2020 +0530
committer Wan-Teh Chang <wtc@google.com> Wed Nov 18 17:05:41 2020 +0000
tree 2864fd31e772681488340f795cb01634a60de00d
parent 5c828d0fcf68b517f7d10b4114cc6d363ac6a69c

Avoid memset in filter_intra_predictor module

Removed memset which is not required in the
av1_filter_intra_predictor module functions.

BUG=aomedia:2878

Change-Id: I48fffed4c81c63f1aec8a2fcf7f41099b21966fc

av1/common/arm/reconintra_neon.c

diff --git a/av1/common/arm/reconintra_neon.c b/av1/common/arm/reconintra_neon.c
index 367d295..ec6d0d7 100644
--- a/av1/common/arm/reconintra_neon.c
+++ b/av1/common/arm/reconintra_neon.c
@@ -102,10 +102,6 @@
   const uint8x8_t vmask_high = vcreate_u8(MASK_HIGH);
 
   assert(bw <= 32 && bh <= 32);
-  // The initialization is just for silencing Jenkins static analysis warnings
-
-  for (r = 0; r < bh + 1; ++r)
-    memset(buffer[r], 0, (bw + 1) * sizeof(buffer[0][0]));
 
   for (r = 0; r < bh; ++r) buffer[r + 1][0] = left[r];
   memcpy(buffer[0], &above[-1], (bw + 1) * sizeof(uint8_t));

av1/common/reconintra.c

diff --git a/av1/common/reconintra.c b/av1/common/reconintra.c
index dd3f90a..9e481b5 100644
--- a/av1/common/reconintra.c
+++ b/av1/common/reconintra.c
@@ -855,10 +855,6 @@
 
   assert(bw <= 32 && bh <= 32);
 
-  // The initialization is just for silencing Jenkins static analysis warnings
-  for (r = 0; r < bh + 1; ++r)
-    memset(buffer[r], 0, (bw + 1) * sizeof(buffer[0][0]));
-
   for (r = 0; r < bh; ++r) buffer[r + 1][0] = left[r];
   memcpy(buffer[0], &above[-1], (bw + 1) * sizeof(uint8_t));
 
@@ -906,10 +902,6 @@
 
   assert(bw <= 32 && bh <= 32);
 
-  // The initialization is just for silencing Jenkins static analysis warnings
-  for (r = 0; r < bh + 1; ++r)
-    memset(buffer[r], 0, (bw + 1) * sizeof(buffer[0][0]));
-
   for (r = 0; r < bh; ++r) buffer[r + 1][0] = left[r];
   memcpy(buffer[0], &above[-1], (bw + 1) * sizeof(buffer[0][0]));
 

av1/common/x86/filterintra_sse4.c

diff --git a/av1/common/x86/filterintra_sse4.c b/av1/common/x86/filterintra_sse4.c
index c11edc1..99f4d99 100644
--- a/av1/common/x86/filterintra_sse4.c
+++ b/av1/common/x86/filterintra_sse4.c
@@ -27,10 +27,6 @@
 
   assert(bw <= 32 && bh <= 32);
 
-  // The initialization is just for silencing Jenkins static analysis warnings
-  for (r = 0; r < bh + 1; ++r)
-    memset(buffer[r], 0, (bw + 1) * sizeof(buffer[0][0]));
-
   for (r = 0; r < bh; ++r) buffer[r + 1][0] = left[r];
   memcpy(buffer[0], &above[-1], (bw + 1) * sizeof(uint8_t));