commit d510b7a581753cb3c2b34a50ff00720a3b778fc4
author James Zern <jzern@google.com> Wed Sep 14 11:33:30 2022 -0700
committer James Zern <jzern@google.com> Thu Sep 15 16:50:46 2022 -0700
tree c21665b1c65c1f64f5132cae80752147405bf779
parent cc26f81b6cd5495a2925424aa403817ad9e5cbc3

obudec,file_is_obu: fix leak on failure

Bug: aomedia:3334
Fixed: aomedia:3334
Change-Id: I839659b268a6b30fd9ff220be843b16eaaa2c23a

common/obudec.c

diff --git a/common/obudec.c b/common/obudec.c
index 650f997..87dd113 100644
--- a/common/obudec.c
+++ b/common/obudec.c
@@ -350,6 +350,7 @@
     if (payload_length > (obu_ctx->buffer_capacity - bytes_read)) {
       fprintf(stderr, "obudec: First OBU's payload is too large\n");
       rewind(f);
+      obudec_free(obu_ctx);
       return 0;
     }
 
@@ -358,6 +359,7 @@
         f, payload_length, &obu_ctx->buffer[bytes_read], &payload_bytes);
     if (status < 0) {
       rewind(f);
+      obudec_free(obu_ctx);
       return 0;
     }
     obu_ctx->bytes_buffered += payload_bytes;
@@ -483,4 +485,9 @@
   return 0;
 }
 
-void obudec_free(struct ObuDecInputContext *obu_ctx) { free(obu_ctx->buffer); }
+void obudec_free(struct ObuDecInputContext *obu_ctx) {
+  free(obu_ctx->buffer);
+  obu_ctx->buffer = NULL;
+  obu_ctx->buffer_capacity = 0;
+  obu_ctx->bytes_buffered = 0;
+}